From nobody Mon Aug 18 14:07:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c5F0p27kjz63jmd; Mon, 18 Aug 2025 14:07:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c5F0p1Hg6z43pr; Mon, 18 Aug 2025 14:07:54 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755526074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaB0CWJbu9guJN1BhL+9hrFYiNU6/DbOdBhVEmjrgvg=; b=Md9to5KLBeBhq3gbs01xrz4BmhSIxPeLx4irx56NHdYQ+UZ2aFN5lhnRwFyK/rmRkVCXcJ JQTjuENIuX7sXIYE5lrABAmOhTItoE0mwQEwr6dMywYO3zf2GxsJhFXw5nVtQwmd6DAuVM BrasANOEz+LNjW+XKc4FHhjaxssKF1PMXAn4TZDFTSNyO1cF0WT/ntLfrjdWauvIJ4KzUR nCiiwLz0w5qolT2jeoQDl7xeSkVLU4kbZF+qvEG0C55Nj7bWYm2Izw99MJu6puzX72+Bv3 VxpitKKXn5AjyNR0tMMOCi8h7lxUAjgWwE5qWTY1nWunNaVDJHZeH7IDawa6KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755526074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DaB0CWJbu9guJN1BhL+9hrFYiNU6/DbOdBhVEmjrgvg=; b=dtKWLHG77RTEdMGn3LQ1y8AzYZOjV8w/fm+woP4Zk09j2T3fDhdMhqeEMyUTbI8rMEV9Dq RiGf51gWSokHUEjolczXlFXKbSB0ZvqtPqM/kwgH99zk7Kx9kjXXcWiW8ABxxKXr+cSB0e b1UUrJRNa9BcT3ps2rozSDxnOS4eSFwLUON9EsSQVuX3c0lloTAHadaxbuba3v+BH10hhV C04cjQ6SlCe6SIJBeq92OSGvf4aq/E/XlS8ds7rarU32fDnP4nKDIVB7DC1QpmSZ2dRaR1 xaBEyJBVyRdQ3Xv+ZW1KoENT+0PmgC06G6FflU3rGhVGMM9hMTaBy3FgMvjiOQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755526074; a=rsa-sha256; cv=none; b=BAzL7PMy7D7EKMu1RgYbWSiSl8eThD8wZyEMDmT4v34QJ0TwQhRDs5yF03YBe2M+FHbxkJ lllhu2CXJs3+TMU0OUWRFPVbJtv3ttzQKqIzLwEaSiEqloP0iMJaqTeyCNHFoLTmzIugat ILK13WKM2/GA5XVD3UmDoqHDFdOmhMY8lsx14jCJiz1eJX7FhHuGf0DijcQHiEAvQM4F9Z nLyQesxZoLCfIDDURSSPgl/PCEyI1EvWXkf1Ks8GVurBs073VkbHQpL2XdPBCT/DrOd5SO FwDajFuA9iH+yMAUpONGz9v1WDmQPcivkG9Ux/V25Z+Dx8HMI4m/rsqYjVeqUw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from [IPV6:2601:5c0:4202:5670:d81:5653:3ddf:690e] (unknown [IPv6:2601:5c0:4202:5670:d81:5653:3ddf:690e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4c5F0n6Nh0zQLq; Mon, 18 Aug 2025 14:07:53 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <77e12d8d-3634-4d6e-bf17-220eca030eb0@FreeBSD.org> Date: Mon, 18 Aug 2025 10:07:53 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: c6778f3a4423 - main - Makefile.libcompat: Tweak krb5 compat dirs Content-Language: en-US To: Lexi Winter , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202508170227.57H2R862074953@gitrepo.freebsd.org> From: John Baldwin In-Reply-To: <202508170227.57H2R862074953@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 8/16/25 22:27, Lexi Winter wrote: > The branch main has been updated by ivy: > > URL: https://cgit.FreeBSD.org/src/commit/?id=c6778f3a4423743a3f30d8d09bc4e4a086863928 > > commit c6778f3a4423743a3f30d8d09bc4e4a086863928 > Author: Lexi Winter > AuthorDate: 2025-08-17 01:19:21 +0000 > Commit: Lexi Winter > CommitDate: 2025-08-17 01:19:21 +0000 > > Makefile.libcompat: Tweak krb5 compat dirs > > krb5/util contains both programs and libraries; trying to build that > for compat confuses bsd.prog.mk and results in unwanted files being > created in the source tree. Remove krb5/util and instead list only > the directories underneath krb5/util which contain libraries. > > The libdata change from the diff isn't included; that will be fixed > in a different way. > > Fixes: fb13ae28b2e8 ("Makefile.libcompat: Add krb5/util") > Reviewed by: ngie (previous version) > Differential Revision: https://reviews.freebsd.org/D51937 Why not just move these directories over to krb5/lib? In fact, I'm not sure why we need a separate krb5/util at all really? Hmm, it seems it builds some bootstrap tools as well as libraries. Note that the order you used here doesn't match the order that krb5/util/Makefile seems to want: SUBDIR= build-tools compile_et .WAIT \ support .WAIT \ et .WAIT \ ss profile verto It does seem though that we could just move the libraries at least into krb5/lib and use .WAIT when needed leaving only build-tools and compile_et in krb5/util? -- John Baldwin