From owner-freebsd-ports@FreeBSD.ORG Sat Jul 7 14:30:34 2012 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2584E1065672 for ; Sat, 7 Jul 2012 14:30:34 +0000 (UTC) (envelope-from bsam@passap.ru) Received: from forward14.mail.yandex.net (forward14.mail.yandex.net [IPv6:2a02:6b8:0:801::4]) by mx1.freebsd.org (Postfix) with ESMTP id 96FFD8FC08 for ; Sat, 7 Jul 2012 14:30:33 +0000 (UTC) Received: from smtp14.mail.yandex.net (smtp14.mail.yandex.net [95.108.131.192]) by forward14.mail.yandex.net (Yandex) with ESMTP id 79D2B1981CD1; Sat, 7 Jul 2012 18:30:32 +0400 (MSK) Received: from smtp14.mail.yandex.net (localhost [127.0.0.1]) by smtp14.mail.yandex.net (Yandex) with ESMTP id 5741B1B600DA; Sat, 7 Jul 2012 18:30:32 +0400 (MSK) Received: from 87.249.28.58.tel.ru (87.249.28.58.tel.ru [87.249.28.58]) by smtp14.mail.yandex.net (nwsmtp/Yandex) with ESMTP id UV7qkwu2-UV7SZuaq; Sat, 7 Jul 2012 18:30:31 +0400 X-Yandex-Rcpt-Suid: vmagerya@gmail.com X-Yandex-Rcpt-Suid: ports@freebsd.org Message-ID: <4FF84807.2060600@passap.ru> Date: Sat, 07 Jul 2012 18:30:31 +0400 From: Boris Samorodov User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:13.0) Gecko/20120620 Thunderbird/13.0.1 MIME-Version: 1.0 To: Vitaly Magerya References: <4FF82A59.7030201@passap.ru> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Cc: ports@freebsd.org Subject: Re: USE_GMAKE fails in QATty? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Jul 2012 14:30:34 -0000 07.07.2012 18:13, Vitaly Magerya пишет: > On 07/07/2012, Boris Samorodov wrote: >> Seems that Mk/bsd.port.mk assumes that LOCALBASE for gmake >> is always /usr/local. Please, try the following patch. >> >> --- bsd.port.mk 1 Jul 2012 20:57:48 -0000 1.732 >> +++ bsd.port.mk 7 Jul 2012 12:20:17 -0000 >> @@ -1647,7 +1647,7 @@ >> EXTRACT_DEPENDS+= unmakeself:${PORTSDIR}/archivers/unmakeself >> .endif >> .if defined(USE_GMAKE) >> -BUILD_DEPENDS+= gmake:${PORTSDIR}/devel/gmake >> +BUILD_DEPENDS+= ${LOCALBASE}/bin/gmake:${PORTSDIR}/devel/gmake >> CONFIGURE_ENV+= MAKE=${GMAKE} >> .endif > > It helps partially: gmake is correctly recognized as installed, > but building ports with it still does not work since GMAKE is > still "gmake". This is additionally needed: > > --- bsd.commands.mk.orig 2012-07-07 16:59:52.000000000 +0300 > +++ bsd.commands.mk 2012-07-07 16:59:44.000000000 +0300 > @@ -43,7 +43,7 @@ > FIND?= /usr/bin/find > FLEX?= /usr/bin/flex > FMT?= /usr/bin/fmt > -GMAKE?= gmake > +GMAKE?= ${LOCALBASE}/bin/gmake > GREP?= /usr/bin/grep > GUNZIP_CMD?= /usr/bin/gunzip -f > GZCAT?= /usr/bin/gzcat Yes, this is the right fix. I've overlooked this. > The problem comes down to the fact that redports/QATty changes > LOCALBASE, but does not put it into PATH. Are ports are supposed > to work without $LOCALBASE/bin in PATH? Maybe it's just a glitch > in redports setup? All ports should support non standard LOCALBASE. Please, submit a PR on the case with both patches and ask to assign to portmgr@. This change needs to be tested at an exp-run. -- WBR, Boris Samorodov (bsam) FreeBSD Committer, http://www.FreeBSD.org The Power To Serve