From owner-svn-src-head@freebsd.org Tue Oct 22 16:39:15 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0324E15F2FA; Tue, 22 Oct 2019 16:39:15 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x435.google.com (mail-pf1-x435.google.com [IPv6:2607:f8b0:4864:20::435]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46yK360lX3z41Pr; Tue, 22 Oct 2019 16:39:13 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x435.google.com with SMTP id 205so10991966pfw.2; Tue, 22 Oct 2019 09:39:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=content-transfer-encoding:from:mime-version:subject:date:message-id :references:cc:in-reply-to:to; bh=4f58rO93MrajBUtAwKwsIxIFnQpeM3oHsCMWfWv4vws=; b=lSjb7krJApiHjUk10N4bLRF874UHVaiaPyFdenj98dYqlb4MQs27wd4eNa9MSx1bFu cSqcV3AU/BOQL+qv0fdNzBTFtSHweMJAJJNzAya1+VjtC0jUIprsgqnTe3IR/RhXqyCj iq889AdjbRwtueNFI8A4DvGYay26pg78qVCg2vHxf3wB5O+u8nLB+Yq2ykh2/tNe/Rkc Wh+W9QVnSwdWROFIAZZKdGwruIppcfAEJWbg3IE9U1+jJCw1DUXGCSH5XnJQgWErBHid Frkbgdf/d3QxNEXhQ48s+Ce1Kv2RLL5neJJTX7JpDzH16PUppFRDBt0JQyNnUreoCOnQ cD8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:content-transfer-encoding:from:mime-version :subject:date:message-id:references:cc:in-reply-to:to; bh=4f58rO93MrajBUtAwKwsIxIFnQpeM3oHsCMWfWv4vws=; b=jpi29nkv9fRduNsMANc6+pKnq5UzK4Q9+ZwvtVET934eE7em88sgkrO2SF9FTNMHgM ElKERuXTqDkvO3ySGzzBAVsk9dk9glMRZK38Ped/nyEoiibcDKyIGtb+qakwb83+b/DU Jxxap88fp6T7kzwRjJEJd5Lobn2jNT0dIcSbNu4JjU1DkH5vglLMmSnPyaX9aGJf4NS1 OfpQv0zv7yCVna62K8hMHDYWi63nBIFlInJQGZemvV+11bibEQw0mlXqBtq/w9ZJulTi OeC5mX3jGYzLe4HYAsQ+iVrfuJ+Lt9niUX0rGhiEghLGQeHcE57QAadD0SKeWwunYpYZ 8oww== X-Gm-Message-State: APjAAAXKsEUpz3XQ9CkaQ6R9Cj2xDRNSGn3pODEprStpWKv5+A/De/IE XYwV6WkWiW5wmSCssiPBmrBbprkl X-Google-Smtp-Source: APXvYqwrFxn4yk9HIF5NXAkuYd9w50U0+d9XdTIgNraH3bv3POKEYLM5XrNR0jy5K20+uCBrBCHQKA== X-Received: by 2002:a63:d246:: with SMTP id t6mr4816747pgi.5.1571762352132; Tue, 22 Oct 2019 09:39:12 -0700 (PDT) Received: from ?IPv6:2607:fb90:8364:7608:20b8:9b0:3e3e:87bc? ([2607:fb90:8364:7608:20b8:9b0:3e3e:87bc]) by smtp.gmail.com with ESMTPSA id z13sm22270122pfg.172.2019.10.22.09.39.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2019 09:39:11 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Enji Cooper Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r353888 - head/sys/vm Date: Tue, 22 Oct 2019 09:39:09 -0700 Message-Id: <6B3B03C7-FF4A-4A57-853A-00090DA0E6D8@gmail.com> References: <201910221559.x9MFxG2R047533@repo.freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org In-Reply-To: <201910221559.x9MFxG2R047533@repo.freebsd.org> To: Konstantin Belousov X-Mailer: iPhone Mail (17A878) X-Rspamd-Queue-Id: 46yK360lX3z41Pr X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=lSjb7krJ; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of yaneurabeya@gmail.com designates 2607:f8b0:4864:20::435 as permitted sender) smtp.mailfrom=yaneurabeya@gmail.com X-Spamd-Result: default: False [-2.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; MV_CASE(0.50)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(0.00)[ip: (-9.16), ipnet: 2607:f8b0::/32(-2.43), asn: 15169(-2.07), country: US(-0.05)]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE_FREEMAIL(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[5.3.4.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Oct 2019 16:39:15 -0000 > On Oct 22, 2019, at 08:59, Konstantin Belousov wrote: >=20 > =EF=BB=BFAuthor: kib > Date: Tue Oct 22 15:59:16 2019 > New Revision: 353888 > URL: https://svnweb.freebsd.org/changeset/base/353888 >=20 > Log: > vm_fault(): extract code to lock the vnode into a helper vn_fault_lock_vn= ode(). =46rom an external perspective, I ask myself, =E2=80=9CWhat is the purpo= se in extracting the code out?=E2=80=9D The answer to this question is missi= ng from the commit message. Thank you, -Enji=