From owner-freebsd-current@FreeBSD.ORG Sun Jul 5 15:14:03 2009 Return-Path: Delivered-To: current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7D60E1065679 for ; Sun, 5 Jul 2009 15:14:03 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121]) by mx1.freebsd.org (Postfix) with ESMTP id 034BA8FC16 for ; Sun, 5 Jul 2009 15:14:02 +0000 (UTC) (envelope-from mav@FreeBSD.org) Received: from [212.86.226.226] (account mav@alkar.net HELO mavbook.mavhome.dp.ua) by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9) with ESMTPSA id 247687764; Sun, 05 Jul 2009 18:13:59 +0300 Message-ID: <4A50C331.3040505@FreeBSD.org> Date: Sun, 05 Jul 2009 18:13:53 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.21 (X11/20090405) MIME-Version: 1.0 To: Lucius Windschuh References: <4A4517BE.9040504@FreeBSD.org> <4A4FEBBC.30203@omnilan.de> <4A5053A8.2060902@FreeBSD.org> <90a5caac0907050729k4b24f2eaj64f7d752bddff1ea@mail.gmail.com> In-Reply-To: <90a5caac0907050729k4b24f2eaj64f7d752bddff1ea@mail.gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: current@freebsd.org Subject: Re: RFC: ATA to CAM integration patch (and gjournaled previuos nodes) X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Jul 2009 15:14:03 -0000 Lucius Windschuh wrote: > Hi Alexander. > > 2009/7/5 Alexander Motin : >> It's never late. I have just uploaded fresh patch: >> http://people.freebsd.org/~mav/cam-ata.20090704.patch > > "make buildworld" with this patch stops in my configuration with: > > /usr/obj/usr/src/tmp/usr/lib/libcam.a(ata_all.o)(.text+0x263): In > function `ata_max_mode': > : undefined reference to `min' > > Simply adding > #ifndef min > #define min(a,b) (((a)<(b))?(a):(b)) > #endif > in ata_all.c helps, obviously. Thanks. -- Alexander Motin