From owner-freebsd-amd64@FreeBSD.ORG Thu Dec 3 15:20:03 2009 Return-Path: Delivered-To: freebsd-amd64@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D7A4A106566B for ; Thu, 3 Dec 2009 15:20:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 921B88FC0A for ; Thu, 3 Dec 2009 15:20:03 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id nB3FK3oT076841 for ; Thu, 3 Dec 2009 15:20:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id nB3FK3Kq076840; Thu, 3 Dec 2009 15:20:03 GMT (envelope-from gnats) Date: Thu, 3 Dec 2009 15:20:03 GMT Message-Id: <200912031520.nB3FK3Kq076840@freefall.freebsd.org> To: freebsd-amd64@FreeBSD.org From: dfilter@FreeBSD.ORG (dfilter service) X-Mailman-Approved-At: Thu, 03 Dec 2009 15:23:08 +0000 Cc: Subject: Re: amd64/141130: commit references a PR X-BeenThere: freebsd-amd64@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: dfilter service List-Id: Porting FreeBSD to the AMD64 platform List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2009 15:20:03 -0000 The following reply was made to PR amd64/141130; it has been noted by GNATS. From: dfilter@FreeBSD.ORG (dfilter service) To: bug-followup@FreeBSD.org Cc: Subject: Re: amd64/141130: commit references a PR Date: Thu, 3 Dec 2009 15:14:45 +0000 (UTC) Author: jhb Date: Thu Dec 3 15:14:30 2009 New Revision: 200061 URL: http://svn.freebsd.org/changeset/base/200061 Log: The fd_mask type is an unsigned long, not an int, so treat the mask as a long instead of an int when examining the results of select() to look for RPC requests. Previously this routine would ignore RPC requests to sockets whose file descriptor mod 64 was greater than 31 on a 64-bit platform. PR: amd64/141130 Submitted by: liujb of array networks MFC after: 3 days Modified: head/lib/libc/rpc/svc.c Modified: head/lib/libc/rpc/svc.c ============================================================================== --- head/lib/libc/rpc/svc.c Thu Dec 3 14:59:42 2009 (r200060) +++ head/lib/libc/rpc/svc.c Thu Dec 3 15:14:30 2009 (r200061) @@ -627,8 +627,8 @@ svc_getreqset(readfds) maskp = readfds->fds_bits; for (sock = 0; sock < FD_SETSIZE; sock += NFDBITS) { - for (mask = *maskp++; (bit = ffs(mask)) != 0; - mask ^= (1 << (bit - 1))) { + for (mask = *maskp++; (bit = ffsl(mask)) != 0; + mask ^= (1ul << (bit - 1))) { /* sock has input waiting */ fd = sock + bit - 1; svc_getreq_common(fd); _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"