Date: Thu, 8 Nov 2012 10:13:33 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Joseph a Nagy Jr <jnagyjr1978@gmail.com> Cc: ports@freebsd.org, Chris Rees <utisoft@gmail.com> Subject: Re: tk85 Port Maintenance Message-ID: <20121108091333.GN90275@gahrfit.gahr.ch> In-Reply-To: <509AEACB.1020909@gmail.com> References: <20121031152109.GD90275@gahrfit.gahr.ch> <CADLo83_VSLt5t31bJbu3-UCuGkNuNnnBEbMXWVd2fhvVwryP5g@mail.gmail.com> <20121031153958.GE90275@gahrfit.gahr.ch> <50915194.6010101@gmail.com> <20121031165507.GF90275@gahrfit.gahr.ch> <509162C9.9060701@gmail.com> <20121102112131.GG90275@gahrfit.gahr.ch> <50968056.8080602@gmail.com> <20121106082040.GM90275@gahrfit.gahr.ch> <509AEACB.1020909@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Xb8pJpF45Qg/t7GZ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2012-Nov-07, 17:12, Joseph a Nagy Jr wrote:
> On 11/06/12 02:20, Pietro Cerutti wrote:
> <snip>
> > * I won't comment on the LICENSE stuff, I don't know enough about it
> >=20
> > * XFT_DESC
> > This is already defined in bsd.options.desc.mk. I'd say that=20
> > "Xft font library" is ok as a description.
> >=20
> > * LIB_DEPENDS+=3D Xft:${PORTSDIR}/x11-fonts/libXft
> > This should really be
> > USE_XORG+=3D xft
> >=20
> > * LIB_DEPENDS=3D tcl${SHORT_TK_VER}${THREADS_SUFFIX}:....
> > If you're ok to wait until I get rid of the -thread slave ports,
> > you don't need to bother about this part of the Makefile
> >=20
>=20
> svn checked out, svn diff
>=20
> http://pastebin.com/kLdUFp9H
-XFT_DESC=3D Use Xft fonts
+XFT_DESC=3D Xft font library
This is not needed. As I said, XFT_DESC is already defined in
bsd.options.desc.mk
The tr -> ${TR} conversion is also wrong, you're changing what the sed
liner is looking for. If you do so, it won't find it anymore.
By the way, Tcl/Tk 8.5.13 is bound to be released in the next few days
(the first RC is out now, actually). You might want to include the
update in your diff :)
--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
--Xb8pJpF45Qg/t7GZ
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (FreeBSD)
iEYEARECAAYFAlCbd7wACgkQwMJqmJVx945TPACeP2oN9uJgfRGnSdL+fTgoNfYE
VLYAnA+LpKpCcl6KyaWCQTTSY7es3V51
=VQ1D
-----END PGP SIGNATURE-----
--Xb8pJpF45Qg/t7GZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121108091333.GN90275>