From owner-svn-src-all@freebsd.org Mon Sep 16 15:28:55 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3558A12587B for ; Mon, 16 Sep 2019 15:28:55 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) Received: from CAN01-TO1-obe.outbound.protection.outlook.com (mail-eopbgr670052.outbound.protection.outlook.com [40.107.67.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46X9BZ1jtNz3LLk for ; Mon, 16 Sep 2019 15:28:53 +0000 (UTC) (envelope-from rmacklem@uoguelph.ca) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LyF+HUn1Oy6nu3uT7HLMEVRTo6lVSFAHY5wdD7njIt0ItEhf8ci5thqmydwen5FQlfrTGKQqIYLbE+93VKyGjyV5ZxNjJ/tOfZkQzNNL2/iFhB3Wtp5R+81Z55Xt0GEnCQHCRFREEcynGQypONSvZmMz1HwcYkVgNtE/KCxU6SamBnhE3bAK//8+9+Cb5ISJYJkAspkT/1A5+ouKRx+W3yodgM5ozrFgK8N8SuxxPQNAXYk2vVZfi6X9nL5eAqYUjFfRKZF21asR7+poeTfsT+Zx+i6Usc8x+sxpLm9GyXAc0BThADeISBg7JgCUflHpEQB3aXDSOAylJ71QAIYHpQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9cAdxeDqNnxZfwwu6YLGWYxtyVOdbIMjF6y9qSH3RiM=; b=KPmVPKakt21PzkitHzp4Y0RpciVtpuDjPs4t4k51rgWIQFZWEkSoqkwKv+n9bd2zX8GlBC4kE44rvCumd70Ny6h+dn/Vrc4WyJRSgZRRcGmrIfW//D1aXwsMnOeAzq/wMmru8WpBsUd33YGJVjCx0HXN2Q8m58r0omNiAU1NJgXZFQq6CXXFbO3HVxzjktOKbqBZVzY7ChUUsbg9X+HOqekJoiywknv4ddCJh1LtFqe8k+5gyuy1OKdTaFXEAhoRHmNA/LeIS5LXmpfYdJ56pyRwtc6+/+J+AfRw4NaR9tqO9ms0B/kjT682BTpmb2zvsrLuDZPQkmvnF+BZfYUhsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=uoguelph.ca; dmarc=pass action=none header.from=uoguelph.ca; dkim=pass header.d=uoguelph.ca; arc=none Received: from YTXPR0101MB2189.CANPRD01.PROD.OUTLOOK.COM (52.132.39.22) by YTXPR0101MB2077.CANPRD01.PROD.OUTLOOK.COM (52.132.37.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2263.23; Mon, 16 Sep 2019 15:28:52 +0000 Received: from YTXPR0101MB2189.CANPRD01.PROD.OUTLOOK.COM ([fe80::5413:22e8:7013:d8b9]) by YTXPR0101MB2189.CANPRD01.PROD.OUTLOOK.COM ([fe80::5413:22e8:7013:d8b9%5]) with mapi id 15.20.2263.023; Mon, 16 Sep 2019 15:28:52 +0000 From: Rick Macklem To: "svn-src-all@freebsd.org" Subject: Re: Re; svn commit: r352393 - head/sys/fs/nfsclient Thread-Topic: Re; svn commit: r352393 - head/sys/fs/nfsclient Thread-Index: AQHVbKIrGKQ8rOwi4UavHi4KjNkUJKcubWwC Date: Mon, 16 Sep 2019 15:28:52 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4f81cc5d-fdaa-475b-92ca-08d73aba9490 x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600167)(711020)(4605104)(1401327)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:YTXPR0101MB2077; x-ms-traffictypediagnostic: YTXPR0101MB2077: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:350; x-forefront-prvs: 0162ACCC24 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(346002)(136003)(396003)(376002)(39860400002)(189003)(199004)(11346002)(46003)(6916009)(446003)(229853002)(6436002)(2351001)(256004)(476003)(5640700003)(9686003)(14444005)(486006)(786003)(316002)(2501003)(2940100002)(33656002)(55016002)(71200400001)(71190400001)(4744005)(2906002)(478600001)(81166006)(52536014)(86362001)(8676002)(25786009)(81156014)(66946007)(64756008)(8936002)(66556008)(76116006)(66476007)(74316002)(305945005)(66446008)(53936002)(99286004)(14454004)(76176011)(102836004)(186003)(53546011)(6246003)(6506007)(5660300002)(7696005); DIR:OUT; SFP:1101; SCL:1; SRVR:YTXPR0101MB2077; H:YTXPR0101MB2189.CANPRD01.PROD.OUTLOOK.COM; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: uoguelph.ca does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: lZZTNLK4bQg0a0TgQauSMU0hsSoq6VmA/LH3o3qmE6xc900ZeT//9JYy3Tl3oBA2BPC5Cz2s+8wdsaBfD+fMsVnc5sGW+n4UF5ni7X7FrtRcvtT7Jb6wBLwcpYb6ynlekthqRCxeJKkDLs5mFHZYbBzZK2Q1S1GMzVliuUb/6ef6ExOfExQexjKyOgZ7uy/ZurbiRA9FY2rfA1cveJ5fkzDxOKTqqfZxHpEk40knsxRhWa8aRZ+i+IDP06RgRAci02iMCj1rVtOYab3VyVlPyoeQyuKJuNYfputQXcVyhA12ml848Hvrv9hQY5OjByNQ/w1ziKCUzHwW92bO/CQs/8EVZXcvyMxjm1c8T4qyeUNiXUNTwL9tUcNlnF7rIVx6Ynh3kvL22/NIAgFBnsMkyd6no0LPfy2rSfgxqcFBt5w= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: uoguelph.ca X-MS-Exchange-CrossTenant-Network-Message-Id: 4f81cc5d-fdaa-475b-92ca-08d73aba9490 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Sep 2019 15:28:52.5856 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: be62a12b-2cad-49a1-a5fa-85f4f3156a7d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CMXkw9cq9ad9yenefRxBsEEeyI3aAjkLAsEkpAhCvvCDAn3RUDYZRbnyB2sw2aJKjXfzMfig5d418SEdnFhEVQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YTXPR0101MB2077 X-Rspamd-Queue-Id: 46X9BZ1jtNz3LLk X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of rmacklem@uoguelph.ca designates 40.107.67.52 as permitted sender) smtp.mailfrom=rmacklem@uoguelph.ca X-Spamd-Result: default: False [-4.54 / 15.00]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:40.107.0.0/16]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[uoguelph.ca]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCPT_COUNT_ONE(0.00)[1]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.24)[ipnet: 40.64.0.0/10(-3.65), asn: 8075(-2.51), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[52.67.107.40.list.dnswl.org : 127.0.3.0]; TO_DN_EQ_ADDR_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:8075, ipnet:40.64.0.0/10, country:US]; ARC_ALLOW(-1.00)[i=1] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Sep 2019 15:28:55 -0000 Resent to correct address...=0A= =0A= ________________________________________=0A= From: Rick Macklem=0A= Sent: Monday, September 16, 2019 11:27 AM=0A= To: kib@freebsd.org; peterj@freebsd.org=0A= Cc: src-svn-all@freebsd.org=0A= Subject: Re; svn commit: r352393 - head/sys/fs/nfsclient=0A= =0A= Hi Kostik,=0A= =0A= I'm afraid there was a reason that only certain cases (where the file was= =0A= being shrunk) did the vnode_pager_setsize() call after the NFS node=0A= lock is released.=0A= =0A= See the commit log message for r252528.=0A= =0A= If vnode_pager_setsize() now acquires a sleep lock for the case where the= =0A= size is increasing, it sounds like the NFS node lock will have to become a= =0A= sleep lock instead of a mutex.=0A= (If needed, I can get working on this in a day or two.)=0A= =0A= rick=0A=