From owner-freebsd-embedded@FreeBSD.ORG Wed May 7 14:47:31 2014 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8A2CC8EE; Wed, 7 May 2014 14:47:31 +0000 (UTC) Received: from mail.xcllnt.net (mail.xcllnt.net [50.0.150.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 30C6FB5; Wed, 7 May 2014 14:47:30 +0000 (UTC) Received: from meganw-sslvpn-nc.jnpr.net ([66.129.239.13]) (authenticated bits=0) by mail.xcllnt.net (8.14.8/8.14.8) with ESMTP id s47ElRHg018043 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Wed, 7 May 2014 07:47:29 -0700 (PDT) (envelope-from marcel@xcllnt.net) Content-Type: multipart/signed; boundary="Apple-Mail=_77C82B65-197C-4B3C-981C-8512893D1E00"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: [RFC] geom_uncompress(4) changes From: Marcel Moolenaar In-Reply-To: Date: Wed, 7 May 2014 07:47:21 -0700 Message-Id: References: To: Luiz Otavio O Souza X-Mailer: Apple Mail (2.1874) Cc: freebsd-embedded , freebsd-geom@freebsd.org X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 May 2014 14:47:31 -0000 --Apple-Mail=_77C82B65-197C-4B3C-981C-8512893D1E00 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii On Apr 29, 2014, at 4:50 AM, Luiz Otavio O Souza wrote: > Hi, > > I've the attached changes to geom_uncompress(4) that modularise the > compression support. > > It can now be built with support to mkuzip(8) or mkulzma(8) (or both) > independently. > > It also make a lot easier to add the support to new compression > methods on geom_uncompress. > > Now, building a kernel with 'options GEOM_UNCOMPRESS' (kept for > backward compatibility) adds only the support to read mkulzma images. You're not quite backward compatible, because GEOM_UNCOMPRESS now includes both lzma and zip. You may want to add GEOM_UNCOMPRESS_ULZMA and document it as the way to add support for lzma. That way you can simply "redefine" GEOM_UNCOMPRESS as meaning any and all compression algorithms. Thus: - GEOM_UNCOMPRESS gives you support for any and all. - GEOM_UNCOMPRESS_FOO gives you support for just FOO. > > I think we could eventually retire geom_uzip(8) as they are doing > essentially the same thing (with the same implementation and code...). > But this lets a lot of open questions regarding backward > compatibility. You can even redefine GEOM_UZIP to do what GEOM_UNCOMPRESS_UZIP does. If the code is effectively the same then compatibility is about the options, not the actual C files underneath... In general: good! -- Marcel Moolenaar marcel@xcllnt.net --Apple-Mail=_77C82B65-197C-4B3C-981C-8512893D1E00 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - http://gpgtools.org iEUEARECAAYFAlNqR3kACgkQpgWlLWHuifaqAwCYwhmdAEdzD1X9lPFEmzg1BaXM HACeLqcmohEBBhRMNhmT2L8GMEqAOiQ= =J8Zq -----END PGP SIGNATURE----- --Apple-Mail=_77C82B65-197C-4B3C-981C-8512893D1E00--