From owner-freebsd-bugs@FreeBSD.ORG Sat Jul 10 00:40:15 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DCB8816A4CF for ; Sat, 10 Jul 2004 00:40:15 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id B745C43D45 for ; Sat, 10 Jul 2004 00:40:15 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id i6A0eFtJ054179 for ; Sat, 10 Jul 2004 00:40:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6A0eFM2054178; Sat, 10 Jul 2004 00:40:15 GMT (envelope-from gnats) Resent-Date: Sat, 10 Jul 2004 00:40:15 GMT Resent-Message-Id: <200407100040.i6A0eFM2054178@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mark Andrews Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 47B0D16A4CE for ; Sat, 10 Jul 2004 00:31:51 +0000 (GMT) Received: from farside.isc.org (farside.isc.org [204.152.187.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3941C43D46 for ; Sat, 10 Jul 2004 00:31:51 +0000 (GMT) (envelope-from Mark_Andrews@isc.org) Received: from drugs.dv.isc.org (localhost [IPv6:::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by farside.isc.org (Postfix) with ESMTP id 6C57CA863 for ; Sat, 10 Jul 2004 00:31:50 +0000 (UTC) (envelope-from marka@isc.org) Received: from drugs.dv.isc.org (localhost [127.0.0.1]) by drugs.dv.isc.org (8.12.11/8.12.11) with ESMTP id i6A0Vla0038671 for ; Sat, 10 Jul 2004 10:31:47 +1000 (EST) (envelope-from marka@drugs.dv.isc.org) Received: (from marka@localhost) by drugs.dv.isc.org (8.12.11/8.12.11/Submit) id i6A0Vlt7038670; Sat, 10 Jul 2004 10:31:47 +1000 (EST) (envelope-from marka) Message-Id: <200407100031.i6A0Vlt7038670@drugs.dv.isc.org> Date: Sat, 10 Jul 2004 10:31:47 +1000 (EST) From: Mark Andrews To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: bin/68881: Fetch corrupts passwords with spaces. X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Mark Andrews List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jul 2004 00:40:16 -0000 >Number: 68881 >Category: bin >Synopsis: Fetch corrupts passwords with spaces. >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Jul 10 00:40:14 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Mark Andrews >Release: FreeBSD 4.10-PRERELEASE i386 >Organization: ISC >Environment: System: FreeBSD drugs.dv.isc.org 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #17: Fri May 14 00:38:53 EST 2004 marka@drugs.dv.isc.org:/usr/obj/usr/src/sys/DRUGS i386 >Description: Fetch corrupts passwords with spaces. >How-To-Repeat: Create a account with a password that contains one or more spaces. Try to use fetch to document that requires the use of that password. >Fix: Index: fetch.c =================================================================== RCS file: /home/ncvs/src/usr.bin/fetch/fetch.c,v retrieving revision 1.10.2.23 diff -u -r1.10.2.23 fetch.c --- fetch.c 12 Apr 2004 19:52:44 -0000 1.10.2.23 +++ fetch.c 10 Jul 2004 00:14:40 -0000 @@ -296,7 +296,7 @@ return -1; for (i = 0; URL->pwd[i]; ++i) - if (isspace(URL->pwd[i])) + if (isspace(URL->pwd[i]) && URL->pwd[i] != ' ') URL->pwd[i] = '\0'; return 0; } >Release-Note: >Audit-Trail: >Unformatted: