Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 10 Jul 2004 10:31:47 +1000 (EST)
From:      Mark Andrews <Mark_Andrews@isc.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   bin/68881: Fetch corrupts passwords with spaces.
Message-ID:  <200407100031.i6A0Vlt7038670@drugs.dv.isc.org>
Resent-Message-ID: <200407100040.i6A0eFM2054178@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         68881
>Category:       bin
>Synopsis:       Fetch corrupts passwords with spaces.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sat Jul 10 00:40:14 GMT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Mark Andrews
>Release:        FreeBSD 4.10-PRERELEASE i386
>Organization:
ISC
>Environment:
System: FreeBSD drugs.dv.isc.org 4.10-PRERELEASE FreeBSD 4.10-PRERELEASE #17: Fri May 14 00:38:53 EST 2004 marka@drugs.dv.isc.org:/usr/obj/usr/src/sys/DRUGS i386


>Description:

	Fetch corrupts passwords with spaces.

>How-To-Repeat:
	
	Create a account with a password that contains one or
	more spaces.  Try to use fetch to document that requires
	the use of that password.

>Fix:

Index: fetch.c
===================================================================
RCS file: /home/ncvs/src/usr.bin/fetch/fetch.c,v
retrieving revision 1.10.2.23
diff -u -r1.10.2.23 fetch.c
--- fetch.c	12 Apr 2004 19:52:44 -0000	1.10.2.23
+++ fetch.c	10 Jul 2004 00:14:40 -0000
@@ -296,7 +296,7 @@
 		return -1;
 
 	for (i = 0; URL->pwd[i]; ++i)
-		if (isspace(URL->pwd[i]))
+		if (isspace(URL->pwd[i]) && URL->pwd[i] != ' ')
 			URL->pwd[i] = '\0';
 	return 0;
 }
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407100031.i6A0Vlt7038670>