From owner-freebsd-current Thu Mar 7 20:33:48 2002 Delivered-To: freebsd-current@freebsd.org Received: from apollo.backplane.com (apollo.backplane.com [216.240.41.2]) by hub.freebsd.org (Postfix) with ESMTP id 0E06037B405; Thu, 7 Mar 2002 20:33:46 -0800 (PST) Received: (from dillon@localhost) by apollo.backplane.com (8.11.6/8.9.1) id g284XcV72256; Thu, 7 Mar 2002 20:33:38 -0800 (PST) (envelope-from dillon) Date: Thu, 7 Mar 2002 20:33:38 -0800 (PST) From: Matthew Dillon Message-Id: <200203080433.g284XcV72256@apollo.backplane.com> To: Garance A Drosihn Cc: Jake Burkholder , Robert Watson , FreeBSD current users Subject: Re: Patch for critical_enter()/critical_exit() & interrupt assem References: <200203072143.g27LhaL97112@harmony.village.org> <20020307205844.C12044@locore.ca> <200203080304.g2834n571759@apollo.backplane.com> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG :Perhaps that part of the update could be considered "cosmetic", and :thus be done as a separate update -- just so people can tell which :lines are cosmetic changes and which ones are substantive. That is :more work for you, but it makes it easier on reviewers, and it is :certainly consistent with what developers are asked to do on other :updates they make. : :You'll still probably have a debate on the "wonderfulness" of that :cosmetic change, but at least it makes it easier for the major :changes to looked at and commented on separately. : :-- :Garance Alistair Drosehn = gad@eclipse.acs.rpi.edu Ugh. I'd rather not. It would take a while to unwind the tabbing from the deferred interrupts. i.e. I didn't just cleanup the syntax in icu_vector.s, I also had to implement the same stuff I put in apic_vector.s to support deferred interrupts. -Matt To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message