From owner-svn-src-head@FreeBSD.ORG Mon Mar 11 00:42:24 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5C18F53F; Mon, 11 Mar 2013 00:42:24 +0000 (UTC) (envelope-from alc@rice.edu) Received: from pp2.rice.edu (proofpoint2.mail.rice.edu [128.42.201.101]) by mx1.freebsd.org (Postfix) with ESMTP id 267DB9B8; Mon, 11 Mar 2013 00:42:23 +0000 (UTC) Received: from pps.filterd (pp2.rice.edu [127.0.0.1]) by pp2.rice.edu (8.14.5/8.14.5) with SMTP id r2B0Om7Z015492; Sun, 10 Mar 2013 19:42:17 -0500 Received: from mh3.mail.rice.edu (mh3.mail.rice.edu [128.42.199.10]) by pp2.rice.edu with ESMTP id 1ayt5drfee-1; Sun, 10 Mar 2013 19:42:17 -0500 X-Virus-Scanned: by amavis-2.7.0 at mh3.mail.rice.edu, auth channel Received: from adsl-216-63-78-18.dsl.hstntx.swbell.net (adsl-216-63-78-18.dsl.hstntx.swbell.net [216.63.78.18]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) (Authenticated sender: alc) by mh3.mail.rice.edu (Postfix) with ESMTPSA id 86C4B40023; Sun, 10 Mar 2013 19:42:16 -0500 (CDT) Message-ID: <513D2867.2020206@rice.edu> Date: Sun, 10 Mar 2013 19:42:15 -0500 From: Alan Cox User-Agent: Mozilla/5.0 (X11; FreeBSD i386; rv:17.0) Gecko/20130127 Thunderbird/17.0.2 MIME-Version: 1.0 To: Andre Oppermann Subject: Re: svn commit: r248031 - in head/sys: kern sys References: <201303081014.r28AEwet053196@svn.freebsd.org> <513A2B3E.2070804@rice.edu> <513D0F80.80405@freebsd.org> In-Reply-To: <513D0F80.80405@freebsd.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=5400 definitions=5800 signatures=585085 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 ipscore=0 suspectscore=4 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1111160001 definitions=main-1101130121 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2013 00:42:24 -0000 On 03/10/2013 17:56, Andre Oppermann wrote: > On 08.03.2013 19:17, Alan Cox wrote: >> On 03/08/2013 04:14, Andre Oppermann wrote: >>> Author: andre >>> Date: Fri Mar 8 10:14:58 2013 >>> New Revision: 248031 >>> URL: http://svnweb.freebsd.org/changeset/base/248031 >>> >>> Log: >>> Move the auto-sizing of the callout array from init_param2() to >>> kern_timeout_callwheel_alloc() where it is actually used. >>> >>> This is a mechanical move and no tuning parameters are changed. >>> >>> The pre-allocated callout array is only used for legacy timeout(9) >>> calls and is only allocated and active on cpu0. Eventually all >>> remaining users of timeout(9) should switch to the callout_* API. >>> >> >> In the meantime, until all legacy timeout(9) users are updated, I think >> that it would be wise to retain the comment that describes where the >> magic number 18508 comes from. > > A valid point. Reintroduced in r248141. Thank you!