From owner-freebsd-arch@FreeBSD.ORG  Wed Jul 30 18:43:21 2008
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2E6751065673;
	Wed, 30 Jul 2008 18:43:21 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id CCCEF8FC14;
	Wed, 30 Jul 2008 18:43:20 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id m6UIfPKN048125;
	Wed, 30 Jul 2008 12:41:27 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Wed, 30 Jul 2008 12:41:42 -0600 (MDT)
Message-Id: <20080730.124142.1837098050.imp@bsdimp.com>
To: des@des.no
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <86r69buar0.fsf@ds4.des.no>
References: <20080729.161303.709402272.imp@bsdimp.com>
	<86r69buar0.fsf@ds4.des.no>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: kan@freebsd.org, arch@freebsd.org, pjd@freebsd.org
Subject: Re: Need a code review
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 30 Jul 2008 18:43:21 -0000

In message: <86r69buar0.fsf@ds4.des.no>
            Dag-Erling_Sm=F8rgrav <des@des.no> writes:
: "M. Warner Losh" <imp@bsdimp.com> writes:
: > http://people.freebsd.org/~gonzo/mips2/libpam.diff
: =

: This won't work.  Your patch unconditionally sets NO_STATIC_MODULES
: which will result in a non-functional libpam.a (the modules will be
: built into the library, but without any of the glue that allows the
: library to find them) not just on mips, but on all other platforms.

Thanks for the feedback.  We'll try to fix it.  Good catch.

Warner