From owner-freebsd-bugs@FreeBSD.ORG Thu Apr 22 06:50:18 2004 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id BF9C816A4CF for ; Thu, 22 Apr 2004 06:50:18 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9FB0043D2D for ; Thu, 22 Apr 2004 06:50:18 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i3MDoIbv040469 for ; Thu, 22 Apr 2004 06:50:18 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.10/8.12.10/Submit) id i3MDoIvq040468; Thu, 22 Apr 2004 06:50:18 -0700 (PDT) (envelope-from gnats) Resent-Date: Thu, 22 Apr 2004 06:50:18 -0700 (PDT) Resent-Message-Id: <200404221350.i3MDoIvq040468@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Ken Stailey Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 417C916A4CE; Thu, 22 Apr 2004 06:49:25 -0700 (PDT) Received: from bsdlab.tf-md.net (64-93-1-35.client.dsl.net [64.93.1.35]) by mx1.FreeBSD.org (Postfix) with ESMTP id BAF7B43D39; Thu, 22 Apr 2004 06:49:24 -0700 (PDT) (envelope-from kstailey@bsdlab.tf-md.net) Received: from bsdlab.tf-md.net (localhost.tf-md.net [127.0.0.1]) by bsdlab.tf-md.net (8.12.10/8.12.10) with ESMTP id i3MDjNDt006086; Thu, 22 Apr 2004 09:49:23 -0400 (EDT) (envelope-from kstailey@bsdlab.tf-md.net) Received: (from kstailey@localhost) by bsdlab.tf-md.net (8.12.10/8.12.10/Submit) id i3MDjNdG006085; Thu, 22 Apr 2004 09:45:23 -0400 (EDT) (envelope-from kstailey) Message-Id: <200404221345.i3MDjNdG006085@bsdlab.tf-md.net> Date: Thu, 22 Apr 2004 09:45:23 -0400 (EDT) From: Ken Stailey To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 cc: tjr@FreeBSD.org Subject: bin/65889: vmstat needs to use unsigned printf for forkstats X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Ken Stailey List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Apr 2004 13:50:19 -0000 >Number: 65889 >Category: bin >Synopsis: vmstat needs to use unsigned printf for forkstats >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Apr 22 06:50:18 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Ken Stailey >Release: FreeBSD 5.2.1-RELEASE-p3 i386 >Organization: self >Environment: System: FreeBSD bsdlab.tf-md.net 5.2.1-RELEASE-p3 FreeBSD 5.2.1-RELEASE-p3 #7: Sun Mar 21 10:31:17 EST 2004 kstailey@bsdlab.tf-md.net:/usr/obj/usr/src/sys/BSDLAB i386 >Description: uses u_int but vmsstat.c printf's with %d not %u. Causes signed overflow on busy systems. >How-To-Repeat: Run "vmstat -f" on a busy nameserver or other system with a piggy daemon that forks a lot. >Fix: Index: vmstat.c =================================================================== RCS file: /u1/cvsup/FreeBSD-cvs/root/src/src/usr.bin/vmstat/vmstat.c,v retrieving revision 1.69 diff -u -r1.69 vmstat.c --- vmstat.c 9 Nov 2003 20:39:56 -0000 1.69 +++ vmstat.c 22 Apr 2004 13:40:28 -0000 @@ -654,15 +654,15 @@ { kread(X_SUM, &sum, sizeof(sum)); - (void)printf("%d forks, %d pages, average %.2f\n", + (void)printf("%u forks, %u pages, average %.2f\n", sum.v_forks, sum.v_forkpages, sum.v_forks == 0 ? 0.0 : (double)sum.v_forkpages / sum.v_forks); - (void)printf("%d vforks, %d pages, average %.2f\n", + (void)printf("%u vforks, %u pages, average %.2f\n", sum.v_vforks, sum.v_vforkpages, sum.v_vforks == 0 ? 0.0 : (double)sum.v_vforkpages / sum.v_vforks); - (void)printf("%d rforks, %d pages, average %.2f\n", + (void)printf("%u rforks, %u pages, average %.2f\n", sum.v_rforks, sum.v_rforkpages, sum.v_rforks == 0 ? 0.0 : (double)sum.v_rforkpages / sum.v_rforks); >Release-Note: >Audit-Trail: >Unformatted: