From owner-cvs-all  Wed Dec  1 19: 2:22 1999
Delivered-To: cvs-all@freebsd.org
Received: from coconut.itojun.org (coconut.itojun.org [210.160.95.97])
	by hub.freebsd.org (Postfix) with ESMTP
	id D3FEF14D1A; Wed,  1 Dec 1999 19:02:16 -0800 (PST)
	(envelope-from itojun@itojun.org)
Received: from kiwi.itojun.org (localhost.itojun.org [127.0.0.1])
	by coconut.itojun.org (8.9.3+3.2W/3.7W) with ESMTP id LAA04443;
	Thu, 2 Dec 1999 11:59:59 +0900 (JST)
To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Cc: mgp@mew.org
Cc: sumikawa@ebina.hitachi.co.jp
In-reply-to: sumikawa's message of Thu, 02 Dec 1999 11:53:33 JST.
      <19991202115333O.sumikawa@ebina.hitachi.co.jp> 
X-Template-Reply-To: itojun@itojun.org
X-Template-Return-Receipt-To: itojun@itojun.org
X-PGP-Fingerprint: F8 24 B4 2C 8C 98 57 FD  90 5F B4 60 79 54 16 E2
Subject: Re: BROKEN port on FreeBSD-current 
From: itojun@iijlab.net
Date: Thu, 02 Dec 1999 11:59:59 +0900
Message-ID: <4441.944103599@coconut.itojun.org>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>kris        1999/12/01 10:57:10 PST
>  Modified files:
>    japanese/magicpoint  Makefile 
>  Log:
>  Mark as BROKEN due to buffer overflow yielding setgid uucp. This also needs
>  a portlint.
>  Submitted by:	Brock Tellier <btellier@usa.net>

	I believe this to fix the problem.  Could anyone check?
	(already in magicpoint repository)

itojun


Index: uucplock.c
===================================================================
RCS file: /home/wide/itojun/cvsroot/mgp/kit/contrib/xmindpath/uucplock.c,v
retrieving revision 1.1
diff -c -r1.1 uucplock.c
*** uucplock.c	1998/08/23 04:50:17	1.1
--- uucplock.c	1999/12/02 02:57:21
***************
*** 55,61 ****
  	char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
  	off_t lseek();
  
! 	(void)sprintf(tbuf, _PATH_LOCKDIRNAME, ttyname);
  	fd = open(tbuf, O_RDWR|O_CREAT|O_EXCL, 0664);
  	if (fd < 0) {
  		/*
--- 55,61 ----
  	char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
  	off_t lseek();
  
! 	(void)snprintf(tbuf, sizeof(tbuf), _PATH_LOCKDIRNAME, ttyname);
  	fd = open(tbuf, O_RDWR|O_CREAT|O_EXCL, 0664);
  	if (fd < 0) {
  		/*
***************
*** 104,109 ****
  {
  	char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
  
! 	(void)sprintf(tbuf, _PATH_LOCKDIRNAME, ttyname);
  	return(unlink(tbuf));
  }
--- 104,109 ----
  {
  	char tbuf[sizeof(_PATH_LOCKDIRNAME) + MAXNAMLEN];
  
! 	(void)snprintf(tbuf, sizeof(tbuf), _PATH_LOCKDIRNAME, ttyname);
  	return(unlink(tbuf));
  }


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message