From owner-svn-ports-all@FreeBSD.ORG Sun Nov 16 11:33:51 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 04345136; Sun, 16 Nov 2014 11:33:51 +0000 (UTC) Received: from mail-wg0-x22a.google.com (mail-wg0-x22a.google.com [IPv6:2a00:1450:400c:c00::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 81ABBCA9; Sun, 16 Nov 2014 11:33:50 +0000 (UTC) Received: by mail-wg0-f42.google.com with SMTP id z12so4565372wgg.15 for ; Sun, 16 Nov 2014 03:33:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=M74zlMWfBB9XfllIzIy+YWUB6/vXhvqSh1VVOx+0WaU=; b=M0iZjjnXXCXWYXclVAf759pEpRA+PRngWCfurojx45wAVl/SXFk4qAEEE3L21EPfyd /oe4muOZX0MJDZcr2fB4unBtLvcekM4SioxFE/IPc4ceCNw8UA+M1/vqOa9nySPSXXHG Yf7dv97XrrIZ4aRbn9RDAFnbJYd7H+pBLIH6aUINNIbYcBHdXOkIgyEomsEULNyxNhqi JZauNQxG2gjdod9GgzsmTqUhxm+f1IO200x1ZYotftju9TYqFFTNgQsALcdPJeoisbQv e8ioWVxZAqIJwnwlSfxiJRIsyv20DvRGSWA7MUSE5BL5S15ahHaW3+KSMWMxSSzw+YVk 7lnQ== X-Received: by 10.194.203.105 with SMTP id kp9mr2178145wjc.81.1416137628953; Sun, 16 Nov 2014 03:33:48 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id cm18sm23273197wjb.25.2014.11.16.03.33.47 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 16 Nov 2014 03:33:48 -0800 (PST) Sender: Baptiste Daroussin Date: Sun, 16 Nov 2014 12:33:45 +0100 From: Baptiste Daroussin To: Mathieu Arnold Subject: Re: svn commit: r372622 - in head/editors/vim: . files Message-ID: <20141116113345.GG45145@ivaldir.etoilebsd.net> References: <201411160232.sAG2WJ4Z084790@svn.freebsd.org> <54687C89.20206@gmx.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="2E/hm+v6kSLEYT3h" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, Olli Hauer , svn-ports-all@freebsd.org, Alfred Perlstein , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 16 Nov 2014 11:33:51 -0000 --2E/hm+v6kSLEYT3h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Nov 16, 2014 at 12:24:04PM +0100, Mathieu Arnold wrote: > +--On 16 novembre 2014 11:29:29 +0100 olli hauer wrote: > |> +.if ${PORT_OPTIONS:MDEFAULT_VIMRC} > |> + ${INSTALL_DATA} ${FILESDIR}/vimrc > |> ${STAGEDIR}${DEFAULT_VIMRC_LOCATION}/vimrc +.endif > |> =20 > | ... > |=20 > | Thanks for installing a default vimrc file, but isn't it safer to insta= ll > | the vimrc file with the @sample macro to protect users having already a > | own vimrc file installed? >=20 > Yes, please, install a .sample file and use @sample in the plist, you're > going to overwrite people's existing vimrc. >=20 I first asked alfred to do such before the commit. But when looking at how vim handles vimrc this is a fallback location hence= this vimrc is only loaded only if there is no user supplied vimrc ':version' will show you: system vimrc file: "$VIM/vimrc" user vimrc file: "$HOME/.vimrc" 2nd user vimrc file: "~/.vim/vimrc" user exrc file: "$HOME/.exrc" fall-back for $VIM: "/usr/local/share/vim" So now I'm thinking there is no need for a @sample ...vimrc.sample given th= is vimrc is doing to be installed in the fall-back location. But I do not think adding yet another option is worth, it should probably a= lways be installed. Regards, Bapt --2E/hm+v6kSLEYT3h Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlRoi5kACgkQ8kTtMUmk6EzPDgCcDrz4D4e2zxLprve5UOW0CJGi 5wQAoIr9QmAvQ5W9V3LZFkUDjNfeMGhF =uBrv -----END PGP SIGNATURE----- --2E/hm+v6kSLEYT3h--