From owner-svn-src-head@freebsd.org  Tue Nov 22 20:42:12 2016
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 876D3C5041A;
 Tue, 22 Nov 2016 20:42:12 +0000 (UTC)
 (envelope-from shurd@sasktel.net)
Received: from mail144c7.megamailservers.com (mail544c7.megamailservers.com
 [209.235.141.44])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B6AC51333;
 Tue, 22 Nov 2016 20:42:10 +0000 (UTC)
 (envelope-from shurd@sasktel.net)
X-Authenticated-User: hurds.sasktel.net
X-VIP: 69.49.109.87
Received: from [192.168.0.33] (ip72-194-73-141.oc.oc.cox.net [72.194.73.141])
 (authenticated bits=0)
 by mail144c7.megamailservers.com (8.14.9/8.13.1) with ESMTP id uAMKXpq1003307; 
 Tue, 22 Nov 2016 15:33:56 -0500
Subject: Re: svn commit: r308696 - in head: share/man/man4 sys/boot/forth
 sys/conf sys/dev/bnxt sys/modules sys/modules/bnxt
To: cem@freebsd.org, Stephen Hurd <shurd@freebsd.org>,
 Stephen Hurd <stephen.hurd@broadcom.com>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201611152035.uAFKZTQB045021@repo.freebsd.org>
 <CAG6CVpVgUaBB_U+jMvee2E2XrjKxorhrTmVMMtZQrSvpypthQQ@mail.gmail.com>
From: Stephen Hurd <shurd@sasktel.net>
Message-ID: <5834ABAE.50802@sasktel.net>
Date: Tue, 22 Nov 2016 12:33:50 -0800
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:43.0) Gecko/20100101
 Firefox/43.0 SeaMonkey/2.40
MIME-Version: 1.0
In-Reply-To: <CAG6CVpVgUaBB_U+jMvee2E2XrjKxorhrTmVMMtZQrSvpypthQQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-CTCH-RefID: str=0001.0A020201.5834ABB5.01F8, ss=1, re=0.000, recu=0.000,
 reip=0.000, cl=1, cld=1, fgs=0
X-CTCH-VOD: Unknown
X-CTCH-Spam: Unknown
X-CTCH-Score: 0.000
X-CTCH-Rules: 
X-CTCH-Flags: 0
X-CTCH-ScoreCust: 0.000
X-CSC: 0
X-CHA: v=2.2 cv=J+fa1EvS c=1 sm=1 tr=0 a=l4Y+EJuLrT/8f1z5FvEQ1g==:117
 a=l4Y+EJuLrT/8f1z5FvEQ1g==:17 a=IkcTkHD0fZMA:10 a=MtZCC52XAMUxWBClqooA:9
 a=QEXdDO2ut3YA:10
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Nov 2016 20:42:12 -0000

Conrad Meyer wrote:
> Hi Stephen,
>
> Coverity reports a missing 'break;' (or explicit /* FALLTHROUGH */) in
> if_bnxt.c:1915.  (The HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASEKR cases
> flow into the HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASELR case.)  CID is
> 1366223.
>
> If the fall-through is intentional, please add the comment.  If it
> isn't, I guess it needs a break statement.
>
> Thanks,
> Conrad

Yes, that needs the break.  I'll get that in today.