From owner-svn-ports-all@FreeBSD.ORG Mon Jul 21 05:58:58 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2C333C31; Mon, 21 Jul 2014 05:58:58 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id EB5892811; Mon, 21 Jul 2014 05:58:56 +0000 (UTC) Received: from [192.168.0.22] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 58FF243B4E; Mon, 21 Jul 2014 00:58:35 -0500 (CDT) Message-ID: <53CCABFA.7090202@marino.st> Date: Mon, 21 Jul 2014 07:58:18 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Tijl Coosemans Subject: Re: svn commit: r362304 - head/x11-toolkits/pango References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st> <20140720113124.GD26778@ivaldir.etoilebsd.net> <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org> <53CBF2D7.4070005@marino.st> <20140721013342.6c17ecdc@kalimero.tijl.coosemans.org> In-Reply-To: <20140721013342.6c17ecdc@kalimero.tijl.coosemans.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, Baptiste Daroussin , svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Jul 2014 05:58:58 -0000 On 7/21/2014 01:33, Tijl Coosemans wrote: >> The is not the only port that sets the explicit-depends configure option >> either. > > Yes I know. It must all be removed. The worst case is the gtk20 port > which forces everything that uses gtk20 to link with many Xorg libraries > for no reason. For no reason? Pango contains symbols from each of those libraries. If you link pango without linking the xorg library, you're going to get a reference error if the linker requires explicit linking. For a linker not requiring explicit linking, it just searches each shared library listed in the dynamic symbols section until it finds the symbol it's looking for. > >> What is the concern here? > > The concern is overlinking. You are forcing everything that uses pango > to link with libm just to fix a few ports that require libm but forget > to link with it explicitly. You are also forcing everything that uses > pangocairo to link with libfreetype and libfontconfig now. It's not the port that requires libm, it's libpango that references libm. As such, it's pango's responsibility to link libm through the pc file. Instead of continuing to go around and around, how about comparing the pc files generated with the option and without it, and let's see what the real difference is (e.g. see if -lfreetype and -lfontconfig are really added to pc file with this setting)? John