From owner-svn-src-head@FreeBSD.ORG Thu Oct 16 21:42:37 2008 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F3C9106569E for ; Thu, 16 Oct 2008 21:42:37 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from gv-out-0910.google.com (gv-out-0910.google.com [216.239.58.184]) by mx1.freebsd.org (Postfix) with ESMTP id D286E8FC1D for ; Thu, 16 Oct 2008 21:42:36 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by gv-out-0910.google.com with SMTP id n8so129244gve.39 for ; Thu, 16 Oct 2008 14:42:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender :to:subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references :x-google-sender-auth; bh=YZMn9dn3j+qKs8O37+9VuJKt6Xpa3adydDpe0wCll0I=; b=FrRcaumNM2aCIeSkWv5GckpmqznjopVHNZ+rTO5SScGLVSGki1yOOjmKjoudnXAWSo Oh4rRbyJAgOiiMEdo7ZamtO9HdpPhPI8n1uc0iul/o/O/zrKElA7l479FvOFScrPns/y pSid0CPtXRSBlCE+SAlixqtoNL1xRUdLCinfo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=GdP7HsJT7kn5xb2oG1F2mH//Dsq56XPnJXouSKF1rVgLbC+2XGMEpqiuBRj4ppOVQD Ez+epSFVxdjXKo8gDUSk8BJPd02o9e+jA22i63nqpbyEqtVMAKBFezLfbhJQBvSnw1oP JiWHqT+qkeZ9EHusHW881zzsvhQEGkcs5JWLA= Received: by 10.103.221.5 with SMTP id y5mr1760348muq.34.1224193355229; Thu, 16 Oct 2008 14:42:35 -0700 (PDT) Received: by 10.103.239.14 with HTTP; Thu, 16 Oct 2008 14:42:34 -0700 (PDT) Message-ID: <3bbf2fe10810161442h3be5dc5al1713aaa173636658@mail.gmail.com> Date: Thu, 16 Oct 2008 23:42:34 +0200 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Rafal Jaworowski" In-Reply-To: <48F79107.1050301@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200810140705.m9E75K3x098307@svn.freebsd.org> <3bbf2fe10810141322o5ee27a2eka8a3a902ced6fc97@mail.gmail.com> <48F79107.1050301@semihalf.com> X-Google-Sender-Auth: 61cc3ecb3d8c30d8 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r183866 - head/sys/dev/usb X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Oct 2008 21:42:37 -0000 2008/10/16, Rafal Jaworowski : > Attilio Rao wrote: > [...] > > > >> > >> Added: head/sys/dev/usb/ehci_mbus.c > > > [...] > > > > Why this includes lockmgr? > > I don't think it needs. > > > It seems required by ehci_softc: struct lock (sc_doorbell_lock) field. Ah gah. IIRC, it was totally unuseful to use a lockmgr there. I will wait for Hans' work to go in before to try to fix that issue. Thanks, Attilio -- Peace can only be achieved by understanding - A. Einstein