From owner-dev-commits-src-main@freebsd.org Thu Jun 10 22:26:47 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 54BF265495B for ; Thu, 10 Jun 2021 22:26:47 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G1JVb1kG8z4hv2 for ; Thu, 10 Jun 2021 22:26:46 +0000 (UTC) (envelope-from kevin.bowling@kev009.com) Received: by mail-yb1-xb34.google.com with SMTP id f84so1616965ybg.0 for ; Thu, 10 Jun 2021 15:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kev009.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KSYbp4QbRyU5mMszLcS73ZGMAkrepLmHzPFFjr66IPI=; b=KqkiM6rptD5BZwDj6Uxq337WH6dYoxdVa1J1VGQbTxGd2W29Gpt30igIhmaQwDsXM9 Wn19Ww650bW4mYQGiiuS1RizlN+yPSLEhSsHofUle3Jn9r9JFgQXYsxXRROAxT/UQ++3 YnNrP/orQQ2OhocLSlp8ThVKsxtrwKh3y6+Sc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KSYbp4QbRyU5mMszLcS73ZGMAkrepLmHzPFFjr66IPI=; b=Iz4Xlbp/CJ0n6zpJE7XkjXt7esdz494XWDklUmqT/Tmg2tA8bTJ6fvIkEgQI7mceuH ZDom+H0zZVKymZ1TSQYtvlMoH0j/AlT1UJ0EuEJDd+62cMm4rvO4Caw+QiwpOs6KG694 jjXI6pE2sgixamf2lXOy8sQVKJ3BVSLm/5bG4iO2YyqzJDrIAwL6GR5mSWpDDOozMaug +KmfTc1HLntiR1dZYeNEDHI+brCh0upIaKB2I0kGdMm+SOtK/Wl4xrCLr/CHK27IHiUA vhtMIkzc4iufRU1F/WgzTdXpvjp3aBfZEw+zKggU3gu6RNI5pIYa38AdWxzAfmdA0z3o qMEg== X-Gm-Message-State: AOAM530MhAcn3aYMevFOgtmF0BHNd+YO5dumX/u1tP0RvLibpgJQpXHC +xSxpeNqnP/4gD1i7087ioOkP08uMokaM4Z+Ph7xRw== X-Google-Smtp-Source: ABdhPJwDxCCOCN8Hk9e1NCAlGjqMTkzx+kfP8Fj9e+QfMNjlXHyegC0PV1SxpwsBYQ3FqhcACBWmU7s/pnOJRm4ehp8= X-Received: by 2002:a25:9809:: with SMTP id a9mr1651869ybo.330.1623364005900; Thu, 10 Jun 2021 15:26:45 -0700 (PDT) MIME-Version: 1.0 References: <202106101948.15AJmlgS021046@gndrsh.dnsmgr.net> In-Reply-To: <202106101948.15AJmlgS021046@gndrsh.dnsmgr.net> From: Kevin Bowling Date: Thu, 10 Jun 2021 15:26:34 -0700 Message-ID: Subject: Re: git: f4d987cd137c - main - mk: WITH_FOO=no now generates a warning To: rgrimes@freebsd.org Cc: "" , Warner Losh , Warner Losh , dev-commits-src-main@freebsd.org, src-committers X-Rspamd-Queue-Id: 4G1JVb1kG8z4hv2 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jun 2021 22:26:47 -0000 Empirically that=E2=80=99s not how FreeBSD works these days and it=E2=80=99= s at least an unsustainable mantra as entities come and go (see TCP as a not too controversial example). Checking in a regression implies some level of ownership to revert it if identified quickly. Making a stepwise improvement or partial improvement and halting further work needs to be a valid contribution in a volunteer project. On Thu, Jun 10, 2021 at 12:49 PM Rodney W. Grimes wrote: > > On Thu, Jun 10, 2021 at 5:46 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > The branch main has been updated by imp: > > > > > > > > URL: > > > > https://cgit.FreeBSD.org/src/commit/?id=3Df4d987cd137cb2d0d54a3e35d9258ca= 7c175d291 > > > > > > > > commit f4d987cd137cb2d0d54a3e35d9258ca7c175d291 > > > > Author: Warner Losh > > > > AuthorDate: 2021-06-10 00:10:12 +0000 > > > > Commit: Warner Losh > > > > CommitDate: 2021-06-10 00:10:52 +0000 > > > > > > > > mk: WITH_FOO=3Dno now generates a warning > > > > > > First off thank you, this may stop some head scratching! > > > > > > But what about WITHOUT_foo=3Dno the symetrical mistake? > > > I see bdrewey raised this in the review, but it was dismissed > > > using the argument that some languages, spanish specifically, > > > allow double negatives. This is computers engineering, > > > and in that field of science double negatives are clearly > > > defined and understood, so using an argument of a language > > > that simply does not apply to the field, IMHO, is an arguement > > > of low standing. > > > > > > > It's not the same, and I'm not solving that error because the mapping > > is ambiguous. I've seen a lot more instances of people using > > WITHOUT_FOO=3Dno unironically because it makes sense to the > > person doing it. I disagree it's not a language issue, because > > language is involved here: how do we assign semantic meaning > > is unclear and I have no desire to get involved in what I clearly > > view as a quagmire. > > > > > > > Also I do not believe =3D=3D is a case insensitive operation > > > so this code fails for NO, No, and nO(sic). > > > > > > > Also true. Again, this isn't perfect. I have no desire to make it > > perfect, because the list isn't finite. > > > > If you'd like to own this issue, feel free, but it's not something I > > wish to pursue further. > > You touched it, you own it. > > > Warner > > > > > > > Regards, > > > Rod > > > > > > > > Many people are used to gnu configure's behavior of changing > > > > --with-foo=3Dno to --without-foo. At the same time, several fol= ks > have > > > > WITH_FOO=3Dno in their config files to enable this ironic form = of > the > > > > option because of an old meme from IRC, a mailing list or the > forums > > > (I > > > > forget which). Add a warning to allow to alert people w/o > breaking > > > POLA. > > > > > > > > Reviewed by: allanjude, bdrewery, manu > > > > MFC After: 2 weeks > > > > Sponsored by: Netflix > > > > Differential Revision: https://reviews.freebsd.org/D30684 > > > > --- > > > > share/mk/bsd.mkopt.mk | 6 ++++++ > > > > 1 file changed, 6 insertions(+) > > > > > > > > diff --git a/share/mk/bsd.mkopt.mk b/share/mk/bsd.mkopt.mk > > > > index 5a9cf1b2f1be..98d23dd46c2a 100644 > > > > --- a/share/mk/bsd.mkopt.mk > > > > +++ b/share/mk/bsd.mkopt.mk > > > > @@ -36,6 +36,9 @@ > > > > # > > > > .for var in ${__DEFAULT_YES_OPTIONS} > > > > .if !defined(MK_${var}) > > > > +.if defined(WITH_${var}) && ${WITH_${var}} =3D=3D "no" > > > > +.warning "Use WITHOUT_${var}=3D1 insetad of WITH_${var}=3Dno" > > > > +.endif > > > > .if defined(WITHOUT_${var}) # WITHOUT always wins > > > > MK_${var}:=3D no > > > > .else > > > > @@ -54,6 +57,9 @@ MK_${var}:=3D yes > > > > # > > > > .for var in ${__DEFAULT_NO_OPTIONS} > > > > .if !defined(MK_${var}) > > > > +.if defined(WITH_${var}) && ${WITH_${var}} =3D=3D "no" > > > > +.warning "Use WITHOUT_${var}=3D1 insetad of WITH_${var}=3Dno" > > > > +.endif > > > > .if defined(WITH_${var}) && !defined(WITHOUT_${var}) # WITHOUT > always > > > wins > > > > MK_${var}:=3D yes > > > > .else > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- > Rod Grimes > rgrimes@freebsd.org > _______________________________________________ > dev-commits-src-main@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/dev-commits-src-main > To unsubscribe, send any mail to " > dev-commits-src-main-unsubscribe@freebsd.org" >