From owner-svn-src-head@FreeBSD.ORG  Thu Jul 29 21:25:37 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 234C5106567B;
	Thu, 29 Jul 2010 21:25:37 +0000 (UTC)
	(envelope-from gabor@FreeBSD.org)
Received: from server.mypc.hu (server.mypc.hu [87.229.73.95])
	by mx1.freebsd.org (Postfix) with ESMTP id CEC2B8FC17;
	Thu, 29 Jul 2010 21:25:36 +0000 (UTC)
Received: from server.mypc.hu (localhost [127.0.0.1])
	by server.mypc.hu (Postfix) with ESMTP id 453B214DC3B4;
	Thu, 29 Jul 2010 23:25:36 +0200 (CEST)
X-Virus-Scanned: amavisd-new at server.mypc.hu
Received: from server.mypc.hu ([127.0.0.1])
	by server.mypc.hu (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024)
	with LMTP id amcZ135pEYTc; Thu, 29 Jul 2010 23:25:34 +0200 (CEST)
Received: from [192.168.1.105] (catv-80-99-92-167.catv.broadband.hu
	[80.99.92.167])
	(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
	(No client certificate requested)
	by server.mypc.hu (Postfix) with ESMTPSA id 7D53914DC39B;
	Thu, 29 Jul 2010 23:25:33 +0200 (CEST)
Message-ID: <4C51F1CA.6080702@FreeBSD.org>
Date: Thu, 29 Jul 2010 23:25:30 +0200
From: Gabor Kovesdan <gabor@FreeBSD.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pt-PT;
	rv:1.9.1.10) Gecko/20100512 Thunderbird/3.0.5
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <201007290011.o6T0BE0l072516@svn.freebsd.org>	<20100729122034.GA28899@stack.nl>
	<20100729.142018.295937982770216853.imp@bsdimp.com>
In-Reply-To: <20100729.142018.295937982770216853.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org, jilles@stack.nl
Subject: Re: svn commit: r210578 - head/usr.bin/grep
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 29 Jul 2010 21:25:37 -0000

Em 2010.07.29. 22:20, M. Warner Losh escreveu:
> In message:<20100729122034.GA28899@stack.nl>
>              Jilles Tjoelker<jilles@stack.nl>  writes:
> : On Thu, Jul 29, 2010 at 12:11:14AM +0000, Gabor Kovesdan wrote:
> :>  Author: gabor
> :>  Date: Thu Jul 29 00:11:14 2010
> :>  New Revision: 210578
> :>  URL: http://svn.freebsd.org/changeset/base/210578
> :
> :>  Log:
> :>    - Some improvements on the exiting code, like replacing memcpy with
> :>      strlcpy/strcpy
> :
> : Hmm, I don't think this is an improvement :(
>
> I agree in this case.  The changes don't actually improve the safety
> of the code, but may make the code slower due to the need to recompute
> the length...
>    
Thanks to both of you for the comments. I'll talk to my mentor and 
revert those changes.

Gabor