From nobody Thu Apr 16 15:04:22 2026 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fxLrk656cz6ZnrM for ; Thu, 16 Apr 2026 15:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fxLrk5FxWz4Hvv for ; Thu, 16 Apr 2026 15:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776351862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=woxFPc+E5A63CMx8Vv+dxUKxZ5EbsRBKaRSeJC4OiJg=; b=rxr/MN8m9tUBJyvFN5c964niCG8LVQ+o7JXuThc4sgw0p2P9R7J3A5z3+rNqVm/rmqltbG J0rqwmpx7q2tNmRc8uxPfJldeRleusWIZXmfkpitKRg98KVc6MiaJz1paYFZ6VBy+g9qiO h3cYuWBVFexgfGJcfzWm/St8NiGY6FUQ93J/taKqIJcvPkF0hqbpTtOZJY6NHoc6Lxc0z2 GqY2O6ulBIbbBfRyHOpX/+jQyVqIZ3AUAcw68HCOjf20JOwHxmy56IlFTh7FClvVpLFS7t SufR8JsVuLogbHTLCrQHqpCz6gweH/GON+vfnicVuGmxB70rvuJMnIKwl6ZiQQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776351862; a=rsa-sha256; cv=none; b=nBiCJxgS0W6gFIJcFOfe67Elr78wVFkmpQw830OVVFvFbcat5narBNjFfpkOK2FC8oERUF Y37MEgR2swP4xER33ycnhW3OIDkEgV19FESo3kZcZDj7+TKdwtZj2X96HQhvsJaqwrd5h/ 2qNksYzUn0j00PxPOFVKsWw9Jp+LrQMJsaHhWrqn2H5xHV8dApAOaT5FKp7S3lmDcCyrrC yeyaVscRVLIZ7q25bixWEHmrKIqjFbYehk4nibinCrZYeq+1RE6jnjhWHKCVmcfFC8CviG eXqj1FIZKvLZyzcemckwlcZoBsNVfQ96K7bsiIW//yVc+dvcwuYHGELG4WD/Nw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776351862; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=woxFPc+E5A63CMx8Vv+dxUKxZ5EbsRBKaRSeJC4OiJg=; b=bmWdAY5Xoj3bo/tklpJk0SSriArk9Bg82kx9IwIw9bZuOq00EIkUIFpz/R0SAzhqAksIhC hVhZo2Or1j0E+7F9t4mM8an16m+3HWH4H/3lGVRJW71obUz+I0FEv/KWuRI5LN4KaFjuvI KF4qs2kmkJOU+46GJ10byB8yCSB3DUX2yqd47QlKnd67mCj54SUaOHTUDAOb358sbMvo/y SFKlGU0qAF9aXx9NuQbn+FCkmreMpwb1qmlo+MAilcZ32VLwfUfDICbeR46qNc2P9P3L8L 1VZjGePVXOHNTa4qUe8TKBYln13QEXPm62yr5utmDAyivVgLVUtxdP3f14xFWA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fxLrk4XFwz1BwN for ; Thu, 16 Apr 2026 15:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1cb50 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 16 Apr 2026 15:04:22 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Colin Percival Subject: git: 62a81003536e - stable/15 - clapic_handle_intr: KASSERT isrc != NULL List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 62a81003536ee6f06707b460e79cae348a7a71d2 Auto-Submitted: auto-generated Date: Thu, 16 Apr 2026 15:04:22 +0000 Message-Id: <69e0fa76.1cb50.16a4b6d0@gitrepo.freebsd.org> The branch stable/15 has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=62a81003536ee6f06707b460e79cae348a7a71d2 commit 62a81003536ee6f06707b460e79cae348a7a71d2 Author: Colin Percival AuthorDate: 2026-03-14 01:03:44 +0000 Commit: Colin Percival CommitDate: 2026-04-16 15:03:58 +0000 clapic_handle_intr: KASSERT isrc != NULL If an interrupt arrives at a CPU which isn't expecting that particular vector, intr_lookup_source will return an isrc of NULL and we'll panic when intr_execute_handlers increments *isrc->is_count. Place a KASSERT a few nanoseconds earlier in order to leave some more breadcrumbs for the next person to trip over this behaviour. Tested on: EC2 r8i.96xlarge MFC after: 3 weeks Sponsored by: Amazon Differential Revision: https://reviews.freebsd.org/D55851 (cherry picked from commit f350063a251c9da0c5ce437eb4c44a2d716b673e) --- sys/x86/x86/local_apic.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c index 54026f83dc15..ed9f985dafd5 100644 --- a/sys/x86/x86/local_apic.c +++ b/sys/x86/x86/local_apic.c @@ -1426,6 +1426,9 @@ lapic_handle_intr(int vector, struct trapframe *frame) isrc = intr_lookup_source(apic_idt_to_irq(PCPU_GET(apic_id), vector)); + KASSERT(isrc != NULL, + ("lapic_handle_intr: vector %d unrecognized at lapic %u", + vector, PCPU_GET(apic_id))); intr_execute_handlers(isrc, frame); }