From owner-svn-src-stable-7@FreeBSD.ORG Sun Sep 19 21:10:14 2010 Return-Path: Delivered-To: svn-src-stable-7@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6B1101065670; Sun, 19 Sep 2010 21:10:14 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 151E18FC13; Sun, 19 Sep 2010 21:10:13 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 737D745C89; Sun, 19 Sep 2010 22:49:13 +0200 (CEST) Received: from localhost (chello089077043238.chello.pl [89.77.43.238]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 5F80945685; Sun, 19 Sep 2010 22:49:08 +0200 (CEST) Date: Sun, 19 Sep 2010 22:48:47 +0200 From: Pawel Jakub Dawidek To: Alexander Motin Message-ID: <20100919204847.GA21347@garage.freebsd.pl> References: <201009191957.o8JJvFNX014126@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ" Content-Disposition: inline In-Reply-To: <201009191957.o8JJvFNX014126@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.6 required=4.5 tests=BAYES_00,RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-7@freebsd.org Subject: Re: svn commit: r212878 - stable/7/sys/geom X-BeenThere: svn-src-stable-7@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 7-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Sep 2010 21:10:14 -0000 --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Sep 19, 2010 at 07:57:15PM +0000, Alexander Motin wrote: > - KASSERT(length > 0 && length >=3D cp->provider->sectorsize && > - length <=3D MAXPHYS, ("g_delete_data(): invalid length %jd", > - (intmax_t)length)); > + KASSERT(length > 0 && length >=3D cp->provider->sectorsize, > + ("g_delete_data(): invalid length %jd", (intmax_t)length)); This check looks a bit strange. Leaving only 'length >=3D cp->provider->sectorsize' part should be enough. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyWdy8ACgkQForvXbEpPzR8AACcC9Wz829XIgQQzm6qkbek5oN+ lokAnjH/lEGEgQ1bCqDCXgmFInsHkg5I =rN7L -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--