From owner-cvs-src@FreeBSD.ORG Fri Aug 19 04:50:09 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 97AD116A41F; Fri, 19 Aug 2005 04:50:09 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6AB7743D45; Fri, 19 Aug 2005 04:50:09 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id j7J4o9SK004511; Fri, 19 Aug 2005 04:50:09 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id j7J4o9gA004510; Fri, 19 Aug 2005 04:50:09 GMT (envelope-from csjp) Message-Id: <200508190450.j7J4o9gA004510@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Fri, 19 Aug 2005 04:50:09 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/kern kern_sysctl.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2005 04:50:09 -0000 csjp 2005-08-19 04:50:08 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/kern kern_sysctl.c Log: Synch with HEAD: MFC revision 1.167 date: 2005/08/08 21:06:42; author: csjp; state: Exp; lines: +2 -0 Drop in a WITNESS_WARN into SYSCTL_IN to make sure that we are not holding any non-sleep-able-locks locks when copyin is called. This gets executed un-conditionally since we have no function to wire the buffer in this direction. MFC revision 1.166 date: 2005/08/08 18:54:35; author: csjp; state: Exp; lines: +6 -1 Check to see if we wired the user-supplied buffers in SYSCTL_OUT, if the buffer has not been wired and we are holding any non-sleep-able locks, drop a witness warning. If the buffer has not been wired, it is possible that the writing of the data can sleep, especially if the page is not in memory. This can result in a number of different locking issues, including dead locks. Approved by: re (kensmith) Revision Changes Path 1.165.2.1 +8 -1 src/sys/kern/kern_sysctl.c