From owner-freebsd-ports-bugs@freebsd.org Wed Sep 2 11:21:30 2015 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A9EA9C8712 for ; Wed, 2 Sep 2015 11:21:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0C7551D1B for ; Wed, 2 Sep 2015 11:21:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t82BLTkf013880 for ; Wed, 2 Sep 2015 11:21:29 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 202832] [PATCH] r391392 broke mail/sylpheed on platforms were time_t is 64 bit long Date: Wed, 02 Sep 2015 11:21:29 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: patch X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: yamagi@yamagi.org X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: ehaupt@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status keywords bug_severity priority component assigned_to reporter flagtypes.name attachments.created Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Sep 2015 11:21:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=202832 Bug ID: 202832 Summary: [PATCH] r391392 broke mail/sylpheed on platforms were time_t is 64 bit long Product: Ports & Packages Version: Latest Hardware: Any OS: Any Status: New Keywords: patch Severity: Affects Some People Priority: --- Component: Individual Port(s) Assignee: ehaupt@FreeBSD.org Reporter: yamagi@yamagi.org Assignee: ehaupt@FreeBSD.org Flags: maintainer-feedback?(ehaupt@FreeBSD.org) Keywords: patch Created attachment 160630 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=160630&action=edit Updated patch to fix breakage on platforms with a 64 bit time_t Hello, r391392 / PR 200053 added a patch to mail/sylpheed which fixes SIGBUS errors on ARM. That patch is wrong, it leads to data corruption on platforms where time_t is 64 bit long: - The macro in procmsg.c:194 is called to read the date header of a message: READ_CACHE_DATA_INT(msginfo->date_t); - msginfo->date_t is a time_t. - When time_t is 32 bit long everything's okay. But when it's a 64 bit value, the memcpy() copies only 32 bit from p to n aka msginfo->date_t aka time_t leaving the upper or (on big endian) lower 32 bits undefined. Attached is an updated patch developed by Christoph Mallon that solves this issue. -- You are receiving this mail because: You are the assignee for the bug.