From owner-freebsd-standards@FreeBSD.ORG Thu Jan 12 08:50:11 2012 Return-Path: Delivered-To: freebsd-standards@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2F8D6106566C for ; Thu, 12 Jan 2012 08:50:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id E2D3E8FC17 for ; Thu, 12 Jan 2012 08:50:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q0C8oA2q018550 for ; Thu, 12 Jan 2012 08:50:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q0C8oAG9018549; Thu, 12 Jan 2012 08:50:10 GMT (envelope-from gnats) Resent-Date: Thu, 12 Jan 2012 08:50:10 GMT Resent-Message-Id: <201201120850.q0C8oAG9018549@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-standards@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Marcus Reid Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E04AD106566B for ; Thu, 12 Jan 2012 08:45:02 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id C654B8FC0C for ; Thu, 12 Jan 2012 08:45:02 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q0C8j2M1017517 for ; Thu, 12 Jan 2012 08:45:02 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q0C8j27e017516; Thu, 12 Jan 2012 08:45:02 GMT (envelope-from nobody) Message-Id: <201201120845.q0C8j27e017516@red.freebsd.org> Date: Thu, 12 Jan 2012 08:45:02 GMT From: Marcus Reid To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: standards/164049: getconf returns bad value for ULLONG_MAX X-BeenThere: freebsd-standards@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Standards compliance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Jan 2012 08:50:11 -0000 >Number: 164049 >Category: standards >Synopsis: getconf returns bad value for ULLONG_MAX >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-standards >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Jan 12 08:50:10 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Marcus Reid >Release: 9-STABLE >Organization: >Environment: FreeBSD seabug.megapath.biz 9.0-STABLE FreeBSD 9.0-STABLE #0: Mon Jan 9 10:53:27 PST 2012 root@seabug.megapath.biz:/usr/obj/usr/src/sys/FARK amd64 >Description: getconf outputs -1 for ULLONG_MAX (and ULONG_MAX on amd64), which seems strange. Another implementation that I checked outputs 18446744073709551615 like it should. >How-To-Repeat: getconf ULLONG_MAX >Fix: Patch attached. It creates a couple of compiler warnings but fixes the problem, maybe there is a better way to do it. Patch attached with submission follows: --- usr.bin/getconf/getconf.c.orig 2011-09-27 01:42:06.444544408 -0700 +++ usr.bin/getconf/getconf.c 2012-01-12 00:15:50.000000000 -0800 @@ -98,7 +98,10 @@ if (argv[optind + 1] == NULL) { /* confstr or sysconf */ if ((valid = find_limit(name, &limitval)) != 0) { if (valid > 0) - printf("%" PRIdMAX "\n", limitval); + if((long long)limitval == -1) + printf("%llu\n", limitval); + else + printf("%lld\n", limitval); else printf("undefined\n"); --- usr.bin/getconf/getconf.h.orig 2011-09-27 01:42:06.444544408 -0700 +++ usr.bin/getconf/getconf.h 2012-01-12 00:15:51.000000000 -0800 @@ -31,7 +31,6 @@ #ifdef STABLE typedef long long intmax_t; -#define PRIdMAX "lld" #else #include #endif >Release-Note: >Audit-Trail: >Unformatted: