Date: Fri, 03 Jun 2011 14:08:04 -0700 From: Doug Barton <dougb@FreeBSD.org> To: Steve Wills <swills@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/databases/mysql-proxy Makefile ports/databases/mysql-proxy/files mysql-proxy.in Message-ID: <4DE94D34.1040108@FreeBSD.org> In-Reply-To: <201105292154.p4TLsEsq051959@repoman.freebsd.org> References: <201105292154.p4TLsEsq051959@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
The script looks good overall. Is there any reason that the for loop could not be in a prestart method? We try to avoid having code run unconditionally. Doug On 05/29/2011 14:54, Steve Wills wrote: > swills 2011-05-29 21:54:14 UTC > > FreeBSD ports repository > > Modified files: > databases/mysql-proxy Makefile > databases/mysql-proxy/files mysql-proxy.in > Log: > - Fix rc script > > PR: ports/157332 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=157332 > Submitted by: Andrei Lavreniyuk<andy.lavr@gmail.com> > > Revision Changes Path > 1.26 +1 -1 ports/databases/mysql-proxy/Makefile > 1.3 +2 -2 ports/databases/mysql-proxy/files/mysql-proxy.in > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/mysql-proxy/Makefile.diff?&r1=1.25&r2=1.26&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/databases/mysql-proxy/files/mysql-proxy.in.diff?&r1=1.2&r2=1.3&f=h > -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DE94D34.1040108>