From owner-freebsd-current  Wed Oct  2  8:53:40 2002
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 2C4F737B401; Wed,  2 Oct 2002 08:53:39 -0700 (PDT)
Received: from dragon.nuxi.com (trang.nuxi.com [66.92.13.169])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id ADAA743E7B; Wed,  2 Oct 2002 08:53:38 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by dragon.nuxi.com (8.12.6/8.12.2) with ESMTP id g92FrbKX073451;
	Wed, 2 Oct 2002 08:53:37 -0700 (PDT)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.6/8.12.5/Submit) id g92FrafS073450;
	Wed, 2 Oct 2002 08:53:36 -0700 (PDT)
Date: Wed, 2 Oct 2002 08:53:36 -0700
From: "David O'Brien" <obrien@FreeBSD.ORG>
To: Tim Robbins <tjr@FreeBSD.ORG>
Cc: Pete Carah <pete@ns.altadena.net>, current@FreeBSD.ORG
Subject: Re: Tool make ordering, or something
Message-ID: <20021002155336.GA73332@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.ORG
Mail-Followup-To: David O'Brien <obrien@FreeBSD.org>,
	Tim Robbins <tjr@FreeBSD.ORG>, Pete Carah <pete@ns.altadena.net>,
	current@FreeBSD.ORG
References: <200210020537.g925bQB1092943@ns.altadena.net> <20021002164648.A79780@dilbert.robbins.dropbear.id.au>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021002164648.A79780@dilbert.robbins.dropbear.id.au>
User-Agent: Mutt/1.4i
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-current.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-current>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-current>
X-Loop: FreeBSD.ORG

On Wed, Oct 02, 2002 at 04:46:48PM +1000, Tim Robbins wrote:
> The best we can do to src/bin/sh is to do something like this:
> 
> #ifndef BOOTSTRAPPING
> 		fmtstr(s, 64, "[%td] ", jp - jobtab + 1);

We know when this hit the tree, so please use:

    #if defined(BOOTSTRAPPING) && (__FreeBSD_version > 5000xy)
        fmtstr(s, 64, "[%lld] ", (long long)(jp - jobtab + 1));
    #else
        fmtstr(s, 64, "[%td] ", jp - jobtab + 1);
    #endif

It makes it clear which is the special case and which is the normal one;
it does not penaltize uptodate -CURRENT systems; and lastely lets us know
that when RELENG_5 is branched, we can totally remove it.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message