Date: Tue, 8 May 2018 10:58:15 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Kyle Evans <kevans@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r333351 - head/usr.bin/grep Message-ID: <20180508105815.GB7299@FreeBSD.org> In-Reply-To: <201805080353.w483rlde033542@repo.freebsd.org> References: <201805080353.w483rlde033542@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, May 08, 2018 at 03:53:47AM +0000, Kyle Evans wrote: > New Revision: 333351 > URL: https://svnweb.freebsd.org/changeset/base/333351 > > Log: > bsdgrep: Allow "-" to be passed to -f to mean "standard input" > > A version of this patch was originally sent to me by se@, matching behavior > from newer versions of GNU grep. > > - if ((f = fopen(fn, "r")) == NULL) > + if (strcmp(fn, "-") == 0) > + f = stdin; This makes sense: when `fn' is "-", `f' is stdin. > - fclose(f); > + if (strcmp(fn, "-") != 0) > + fclose(f); But not this one: why are you checking `fn' again? Shouldn't you fclose(f) if it's not stdin? if (f != stdin) fclose(f); ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180508105815.GB7299>