From owner-svn-src-head@freebsd.org Tue Jul 3 20:07:11 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9A2E610219D1; Tue, 3 Jul 2018 20:07:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 390C695C8F; Tue, 3 Jul 2018 20:07:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 0B804DC42; Tue, 3 Jul 2018 20:07:11 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id CC2385C2; Tue, 3 Jul 2018 20:07:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id t-IDMwoolavd; Tue, 3 Jul 2018 20:07:07 +0000 (UTC) Subject: Re: svn commit: r335906 - head/sys/conf DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com A288D5BC To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807031959.w63JxPA2069044@slippy.cwsent.com> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Message-ID: <6d02404f-a7bb-01c7-3775-7a0349e306be@FreeBSD.org> Date: Tue, 3 Jul 2018 13:07:04 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807031959.w63JxPA2069044@slippy.cwsent.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 20:07:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ Content-Type: multipart/mixed; boundary="N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1"; protected-headers="v1" From: Bryan Drewery To: Cy Schubert Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <6d02404f-a7bb-01c7-3775-7a0349e306be@FreeBSD.org> Subject: Re: svn commit: r335906 - head/sys/conf References: <201807031959.w63JxPA2069044@slippy.cwsent.com> In-Reply-To: <201807031959.w63JxPA2069044@slippy.cwsent.com> --N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 7/3/2018 12:59 PM, Cy Schubert wrote: > In message <201807031924.w63JOi5W051614@repo.freebsd.org>, Bryan=20 > Drewery writes > : >> Author: bdrewery >> Date: Tue Jul 3 19:24:44 2018 >> New Revision: 335906 >> URL: https://svnweb.freebsd.org/changeset/base/335906 >> >> Log: >> No need to make a copy to build genoffset_test.o >> >> Modified: >> head/sys/conf/kern.post.mk >> >> Modified: head/sys/conf/kern.post.mk >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> =3D >> --- head/sys/conf/kern.post.mk Tue Jul 3 19:09:46 2018 (r33590 >> 5) >> +++ head/sys/conf/kern.post.mk Tue Jul 3 19:24:44 2018 (r33590 >> 6) >> @@ -191,14 +191,12 @@ offset.inc: $S/kern/genoffset.sh genoffset.o >> genoffset.o: $S/kern/genoffset.c >> ${CC} -c ${CFLAGS:N-flto:N-fno-common} $S/kern/genoffset.c >> =20 >> -genoffset_test.c: $S/kern/genoffset.c >> - cp $S/kern/genoffset.c genoffset_test.c >> - >> # genoffset_test.o is not actually used for anything - the point of c= ompilin >> g it >> # is to exercise the CTASSERT that checks that the offsets in the off= set.inc >> # _lite struct(s) match those in the original(s).=20 >> -genoffset_test.o: genoffset_test.c offset.inc >> - ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST genoffset_test.= c >> +genoffset_test.o: $S/kern/genoffset.c offset.inc >> + ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c}= \ >> + -o ${.TARGET} >=20 > -o with -c in the previous line will cause an error. -o and -c are fine together. The problem is .ALLSRC duplicating sources from the dependencies read from .depend.genoffset_test.o file. Workaround in r335908. >=20 >> =20 >> assym.inc: $S/kern/genassym.sh genassym.o genoffset_test.o >> NM=3D'${NM}' NMFLAGS=3D'${NMFLAGS}' sh $S/kern/genassym.sh genassym.= o > ${. >> TARGET} >> >=20 >=20 --=20 Regards, Bryan Drewery --N66uQifSC1aSf1iMifRJdrqNP6RkoOJg1-- --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEbBAEBAgAGBQJbO9doAAoJEDXXcbtuRpfPquUH92aRqCMwTG0ax2Hu06Fql/lX Kn3iDz/KaCDnuXmnHJ5sgzbGSgevoqgZQnDJp9lrEvroNbsqsXNfFKw2f19ZOf1f g00nafksrxXCIsbK3IF/uwXiseuEaq7yH4TAXg7Yohy2TtnVgh2bxi2tNrkYgnPO lDCTMlbe2DfnsF0ygu6EcaZ1IgQGEbWMS5J4Jue6GoKr8pWZEZgT6kOuUiUVra8D wRWADypq+jw4ADJmgF8u1YVjrdK9q6Yxx3FphnnGi21Rz+RQoSimuEyQ/vUBsCyI DMa0hWxsNbNLx84T60pPHpfV3BJfCYWZHyxMdwLxX5BOEbQphBAzdxYT9Ia9nQ== =ZtE0 -----END PGP SIGNATURE----- --nrEq6SIfsbZGYTgfSZ5R3mSN64FvoLCIQ--