From owner-cvs-all Mon Oct 21 6:47:18 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8FD7137B401; Mon, 21 Oct 2002 06:47:16 -0700 (PDT) Received: from espresso.q9media.com (espresso.q9media.com [65.39.129.122]) by mx1.FreeBSD.org (Postfix) with ESMTP id F028643E91; Mon, 21 Oct 2002 06:47:15 -0700 (PDT) (envelope-from mike@espresso.q9media.com) Received: by espresso.q9media.com (Postfix, from userid 1002) id C7B4C9BC3; Mon, 21 Oct 2002 09:39:12 -0400 (EDT) Date: Mon, 21 Oct 2002 09:39:12 -0400 From: Mike Barcroft To: Poul-Henning Kamp Cc: Bruce Evans , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/isa npx.c Message-ID: <20021021093912.A80691@espresso.q9media.com> References: <20021021110058.Y8562-100000@gamplex.bde.org> <66391.1035178586@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66391.1035178586@critter.freebsd.dk>; from phk@critter.freebsd.dk on Mon, Oct 21, 2002 at 07:36:26AM +0200 Organization: The FreeBSD Project Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Poul-Henning Kamp writes: > In message <20021021110058.Y8562-100000@gamplex.bde.org>, Bruce Evans writes: > >On Sun, 20 Oct 2002, Poul-Henning Kamp wrote: > > > >> phk 2002/10/20 10:30:30 PDT > >> > >> Modified files: > >> sys/i386/isa npx.c > >> Log: > >> Hide inline assembly if lint is defined. > >> > >> Revision Changes Path > >> 1.133 +1 -1 src/sys/i386/isa/npx.c > > > >Inline assembly was already correctly hidden by a __GNUC__ ifdef. It > >is a feature that broken lints which define __GNUC__ without actually > >being supporting all features of gcc barf on unsupported features. > >Please back this out. > > Our kernel is too __GNUC__ infected to making linting it without > defining __GNUC__ an option. > > At the present time, no other compiler stands a chance at compiling > our kernel, and it therefore seems far more productive to be able > to run lint on the code we have and use, than the code we don't have > and don't use. Can your lint define a constant that is in the implementation namespace (eg. _LINT)? This would at least improve your change to i386's which breaks things if an application happens to `#define lint' in a C90 environment. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message