From owner-svn-ports-head@freebsd.org  Tue Nov 14 11:02:44 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id ED911DBAF65;
 Tue, 14 Nov 2017 11:02:44 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2610:1c1:1:6074::16:84])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id CD7057A082;
 Tue, 14 Nov 2017 11:02:44 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 0C70B1A11D; Tue, 14 Nov 2017 11:02:44 +0000 (UTC)
Date: Tue, 14 Nov 2017 11:02:44 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jan Beich <jbeich@FreeBSD.org>
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r454171 - head/multimedia/libvpx
Message-ID: <20171114110244.GB56721@FreeBSD.org>
References: <201711141014.vAEAEjpT071974@repo.freebsd.org>
 <20171114102535.GA56721@FreeBSD.org> <tvxx-jg27-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tvxx-jg27-wny@FreeBSD.org>
User-Agent: Mutt/1.9.1 (2017-09-22)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Nov 2017 11:02:45 -0000

On Tue, Nov 14, 2017 at 11:44:00AM +0100, Jan Beich wrote:
> Alexey Dokuchaev <danfe@FreeBSD.org> writes:
> > Actually, could you add a real 2319-byte patch file under files/ instead?
> > Last time I wanted to build some older version of `devel/android-tools-adb'
> > which has the same "bug" and could not because the patch was no longer
> > fetchable.  Thank you,
> 
> Why it wasn't fetchable? The GitHub mirror should be identical and is
> already used to fetch the main distfile. Provide more details.

cd /usr/ports/devel/android-tools-adb
svn up -r424893 .
make
...
=> Attempting to fetch https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch
fetch: https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch: size unknown
fetch: https://github.com/android/platform_system_core/commit/b4cff495a1f9.patch: size of remote file is not known
b4cff495a1f9.patch                                    2084  B 6281 kBps 00m00s
=> Fetched file size mismatch (expected 2066, actual 2084)

> I use PATCHFILES to denote unmodified fixes from upstream. Putting them
> under files/ requires generating with --no-prefix and pacifying portlint
> via "make makepatch". That'd be no fun if more than one patch touches
> the same files.

I don't think that this is more important than being unable to svn up
to some past revision and having to play tricks with -DNO_CHECKSUM and
hoping everything will be OK and it's just stupid GitHub changed their
output again.

I also don't understand "generating with --no-prefix" part: why not
simply remove those stupid a/ b/ prefixes by hand?  (Not to mention
that even this is not necessary after patch(1) was pessimized by
pfg@ in r320579.)

You don't have to pacify portlint(1); just ignore it when it gives
you stupid advice.

./danfe