From owner-freebsd-ports@FreeBSD.ORG Wed Dec 13 22:08:19 2006 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id D2B6916A47C for ; Wed, 13 Dec 2006 22:08:19 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.FreeBSD.org (Postfix) with SMTP id D6C5E43CBB for ; Wed, 13 Dec 2006 22:06:37 +0000 (GMT) (envelope-from dougb@FreeBSD.org) Received: (qmail 15740 invoked by uid 399); 13 Dec 2006 22:08:08 -0000 Received: from localhost (HELO ?192.168.0.5?) (dougb@dougbarton.us@127.0.0.1) by localhost with SMTP; 13 Dec 2006 22:08:08 -0000 X-Originating-IP: 127.0.0.1 Message-ID: <458079C6.5050108@FreeBSD.org> Date: Wed, 13 Dec 2006 14:08:06 -0800 From: Doug Barton Organization: http://www.freebsd.org/ User-Agent: Thunderbird 1.5.0.8 (X11/20061125) MIME-Version: 1.0 To: vd@FreeBSD.org References: <7mu003jdyg.wl%kuriyama@imgsrc.co.jp> <457DA05F.8010805@FreeBSD.org> <7mr6v6ht57.wl%kuriyama@imgsrc.co.jp> <457E5DB4.7030204@FreeBSD.org> <7mbqm9ijr9.wl%kuriyama@imgsrc.co.jp> <20061212145124.GA3446@straylight.m.ringlet.net> <457F10E5.5070901@FreeBSD.org> <7mu000h8nz.wl%kuriyama@imgsrc.co.jp> <20061213081318.GB53907@qlovarnika.bg.datamax> In-Reply-To: <20061213081318.GB53907@qlovarnika.bg.datamax> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@FreeBSD.org, Jun Kuriyama Subject: Re: HEADS UP : security/gnupg will be upgraded to 2.0.1 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2006 22:08:19 -0000 Vasil Dimov wrote: > On Wed, Dec 13, 2006 at 10:44:00AM +0900, Jun Kuriyama wrote: >> At Tue, 12 Dec 2006 12:28:21 -0800, >> Doug Barton wrote: > [...] >>> What might make sense is for the gnupg 2.x port to install a gpg >>> symlink to gpg2. I've done that on my own system for convenience sake. >>> That will get hairy if the user tries to install gnupg 1.x though. >>> Both gnupg ports will need logic to handle what to do with the symlink >>> if the other port is installed. >> Seems fine. Like this? > > Just my 2 cents: > > - NLS "Native Language Support" on \ > [...] > +OPTIONS= NLS "Include National Language Support" on \ > > I believe the N in NLS stands for Native. It's National. That's why you have things like en_US, which translates roughly to, "English as spoken in the United States." Whether this is a good idea or not is a whole other kettle of fish. :) (It solves some problems nicely, and creates others, but digress.) > [...] > +verify: checksum > + gpg --verify ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX}.sig > > You are referencing the old gpg executable here (or the link in which > case it does not matter) here. > Is this intentional? Shouldn't it be gpg2? Given that gpg the 1.x binary, gpg the link to gpg2, and gpg2 all have the same functionality when it comes to --verify, I don't think it matters, and it's more intuitive from a bootstrapping perspective. (Users are more likely to have the real gpg 1.x or the symlink already installed than they are to have gpg2 already installed.) Jun, The changes look good. The only thing missing (I discovered to my chagrin the other day) is the PORTDOCS for GnuPG 2. I can work that up if you like. My only other comment is that in pkg-install you could probably simplify: if [ -r ${PKG_PREFIX}/bin/gpg ] || [ -L ${PKG_PREFIX}/bin/gpg ]; then # Skip. else ln -s gpg2 ${PKG_PREFIX}/bin/gpg fi to: if [ ! -e "${PKG_PREFIX}/bin/gpg" ]; then ln -s gpg2 ${PKG_PREFIX}/bin/gpg fi hth, Doug -- This .signature sanitized for your protection