From owner-freebsd-apache@FreeBSD.ORG Sun Jun 29 23:51:24 2014 Return-Path: Delivered-To: apache@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A34F5BCC for ; Sun, 29 Jun 2014 23:51:24 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 85DF9254D for ; Sun, 29 Jun 2014 23:51:24 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s5TNpOjQ054987 for ; Mon, 30 Jun 2014 00:51:24 +0100 (BST) (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: apache@FreeBSD.org Subject: [Bug 191471] [patch] www/mod_perl2 does not build against apache24 Date: Sun, 29 Jun 2014 23:51:24 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports Tree X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: kovert@omniscient.com X-Bugzilla-Status: Needs Triage X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: apache@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-apache@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Support of apache-related ports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 29 Jun 2014 23:51:24 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=191471 --- Comment #3 from kovert@omniscient.com --- The version of the patch I included before failed with make test starting up httpd with an assert because of a function call that was missing from the pre-hook. I've included a second patch that can be dropped in files/ and should build <=2.4 (I did not test on anything other than 2.4). Interestingly, I surveyed a few other OS's that had patched this and they also did not pass the perl test. It looks like the function call in the pre-hook was added for mod_perl specifically (see http://comments.gmane.org/gmane.comp.apache.devel/44263 ). Once that was fixed, httpd still did not start in a make test and it fails because the test regiment's httpd.conf is not compatible with apache 2.4. I did not spend enough time with the test regiment to figure out how to fix this, particularly in a way that is friendly to all versions of apache, but I did test it against mod_perl code I already had and the port does work. If you'll accept the patches, you may want to consider putting them inside a define to indicate that they are experimental or some such because make test does not pass although I suspect this is overkill. I've attached (or am about to) the make test output against perl 5.18 and perl 5.20. The system information is below. I don't have the obj files for the 5.18 instance anymore. thanks, -Todd ############################################################################# perl 5.20: [saidin#5 ~] uname -a FreeBSD saidin.omniscient.com 10.0-STABLE FreeBSD 10.0-STABLE #3 r264686: Sun Apr 20 02:01:59 EDT 2014 kovert@saidin.omniscient.com:/usr/obj/usr/src/sys/GENERIC amd64 [saidin#6 ~] more /var/db/ports/lang_perl5.20/options # This file is auto-generated by 'make config'. # Options for perl5-5.20.0_3 _OPTIONS_READ=perl5-5.20.0_3 _FILE_COMPLETE_OPTIONS_LIST=DEBUG GDBM MULTIPLICITY PERL_64BITINT PTHREAD SITECUSTOMIZE THREADS PERL_MALLOC OPTIONS_FILE_UNSET+=DEBUG OPTIONS_FILE_UNSET+=GDBM OPTIONS_FILE_SET+=MULTIPLICITY OPTIONS_FILE_SET+=PERL_64BITINT OPTIONS_FILE_SET+=PTHREAD OPTIONS_FILE_UNSET+=SITECUSTOMIZE OPTIONS_FILE_SET+=THREADS OPTIONS_FILE_UNSET+=PERL_MALLOC [saidin#7 ~] pkg info perl5 perl5-5.20.0_3 Name : perl5 Version : 5.20.0_3 Installed on : Tue Jun 10 10:26:10 EDT 2014 Origin : lang/perl5.20 Architecture : freebsd:10:x86:64 Prefix : /usr/local Categories : perl5 lang devel Licenses : GPLv1 or ART10 Maintainer : perl@FreeBSD.org WWW : http://www.perl.org/ Comment : Practical Extraction and Report Language Options : DEBUG : off GDBM : off MULTIPLICITY : on PERL_64BITINT : on PERL_MALLOC : off PTHREAD : on SITECUSTOMIZE : off THREADS : on Shared Libs required: libperl.so Annotations : cpe : cpe:/a:perl:perl:5.20.0::~~~freebsd~~ Flat size : 47.8MiB Description : Perl is a language that combines some of the features of C, sed, awk and shell. See the manual page for more hype. There are also many books published by O'Reilly & Assoc. See pod/perlbook.pod for more information. WWW: http://www.perl.org/ ############################################################################# [malbec#66 ~] uname -a FreeBSD malbec.omniscient.com 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260799: Fri Jan 17 05:59:32 UTC 2014 root@zinfandel.omniscient.com:/usr/obj/usr/src/sys/GENERIC amd64 [malbec#67 ~] perl info perl5 Can't open perl script "info": No such file or directory [malbec#68 ~] uname -a FreeBSD malbec.omniscient.com 10.0-RELEASE FreeBSD 10.0-RELEASE #0 r260799: Fri Jan 17 05:59:32 UTC 2014 root@zinfandel.omniscient.com:/usr/obj/usr/src/sys/GENERIC amd64 [malbec#69 ~] pkg info perl5 perl5-5.18.2_2 Name : perl5 Version : 5.18.2_2 Installed on : Tue May 13 01:19:08 UTC 2014 Origin : lang/perl5.18 Architecture : freebsd:10:x86:64 Prefix : /usr/local Categories : perl5 lang devel Licenses : GPLv1 or ART10 Maintainer : perl@FreeBSD.org WWW : http://www.perl.org/ Comment : Practical Extraction and Report Language Options : DEBUG : off GDBM : off MULTIPLICITY : off PERL_64BITINT : on PERL_MALLOC : off PTHREAD : on SITECUSTOMIZE : off THREADS : on USE_PERL : on Shared Libs required: libperl.so Flat size : 48.2MiB Description : Perl is a language that combines some of the features of C, sed, awk and shell. See the manual page for more hype. There are also many books published by O'Reilly & Assoc. See pod/perlbook.pod for more information. WWW: http://www.perl.org/ -- You are receiving this mail because: You are the assignee for the bug.