From owner-cvs-all Wed Oct 4 19:52: 8 2000 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 6C90337B502; Wed, 4 Oct 2000 19:52:05 -0700 (PDT) Received: (from kris@localhost) by freefall.freebsd.org (8.9.3/8.9.2) id TAA47009; Wed, 4 Oct 2000 19:52:05 -0700 (PDT) (envelope-from kris@FreeBSD.org) Date: Wed, 4 Oct 2000 19:52:05 -0700 From: Kris Kennaway To: Kris Kennaway Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/tcpdump addrtoname.c print-atalk.c print-bgp.c print-fr.c print-icmp.c print-rx.c print-sunrpc.c print-telnet.c smbutil.c util.c Message-ID: <20001004195205.A42702@freefall.freebsd.org> References: <200010050249.TAA46160@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200010050249.TAA46160@freefall.freebsd.org>; from kris@FreeBSD.org on Wed, Oct 04, 2000 at 07:49:49PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, Oct 04, 2000 at 07:49:49PM -0700, Kris Kennaway wrote: > kris 2000/10/04 19:49:49 PDT > > Modified files: > contrib/tcpdump addrtoname.c print-atalk.c print-bgp.c > print-fr.c print-icmp.c print-rx.c > print-sunrpc.c print-telnet.c smbutil.c > util.c > Log: > * Buffer-safe string function cleanup. There are a couple of strcpy() > and strcat()s which would be more difficult to fix, but I think they're > safe anyway. > * Don't crash at runtime by overflowing a buffer with constant data in > print-icmp.c on a long hostname. > * Don't overflow a static buffer by trying to decode an AFS ACL into a buffer > which is way too small for it. > > Reviewed by: -audit I tried to contact the tcpdump developers about this a week ago, heard no response :-( Kris -- In God we Trust -- all others must submit an X.509 certificate. -- Charles Forsythe To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message