From nobody Tue Apr 23 19:02:36 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VPBMM3mB5z5Hs4B; Tue, 23 Apr 2024 19:02:39 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VPBMM2vVRz4bSB; Tue, 23 Apr 2024 19:02:39 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713898959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RJS8of/My1AeVFoPPkCllgQtvjL6O6MVS5IsRwSddpM=; b=xNZYIstF+Fg1MNpXzMD4ErGDjsI4525l8PMxOJOM1ihPLegObQ+eX9Zzi7/9MQIqisRrm0 BjoBSnWkA1MEt3R2UYyXeQ47g/cbkf7jhcrwmydDuOOhKFNTW1GvAhvIf3OgU2T8lT0BO5 /UdH4Jp1ZDBZo+iFw1QgbcoJTu7vfKj/Uxi82ccU2ROrJ3gcVHZ3MKoFBrTBFMITQae9i7 7J7jN5qvl8VapvSqZ+uWNDQ+2lOq3rPrnUd3nCt7Seh1VQb4DqXu4EbbvbTkLhxk+4B0a8 y2ETidbbPsipbWM8U80BVr4EOrPmi8C9ER5YcREp+uLUvM1JDiqicq17ZQpwzA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1713898959; a=rsa-sha256; cv=none; b=fDxWD2c0bWI5snjhIJK2uCzm3ta7jTlCHvk1nJDX3pu7AspIYpssFjrjQWh762BZW5vK4x lWavLb0M8KTcDjqrSj6kT3aNTJVsfIQEkI4ROybmsND+kuobIQ1kitTz27hyj+y4BAv4zw vaU77UoGnZpZk1/N4sacbFkPQu/livhHQnykUC3zQAhQ+AQV1O1cI5qyo5oES7gnaRx6t+ ZJv3W6AWTx8Mz6mAYZlNgTbVaqjrOTVFVrSEt/aVnx6NzFiotLOj6lu8j0qEHA+pR42Co5 zcC20U+TF3EL6jPFvOX4zDFo7BxwS60J1Nv9Jd74UcpB/ThWNRnma2dQcefQSg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1713898959; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RJS8of/My1AeVFoPPkCllgQtvjL6O6MVS5IsRwSddpM=; b=rLctRsqfzMZGCxP0yq5kVfxHsY/NDZPZqUhR1hBWEiZHvNlENdTaxGgBLVTD0u5/nx3vOg Hk1c4QDpNPYKt4e1j49b6HYiQ1+Bl8aVt1kc71mxIdx6zwgQ46kICqfTCw1lEU9FQ/2YkA JwLjw/7RGDRz8gaqOiK3q8DyTjXPTW464E9dU21Y7c5MB2xKjXsX0sfQL/sT+ItlY4AOPm mrWUev8HwpXyFyEfe2Cx6YSUxdH3KurwnGtS4NTSLs4c5m6TG0gV9jPpSQEGI/BH6s5GGs +34ZxveRrlkpAcekt0olWver37Q4csAHuAVVyodzVTqRc7gA9u3XqE9zgAaWkA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4VPBML4WhWzhWn; Tue, 23 Apr 2024 19:02:38 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Tue, 23 Apr 2024 12:02:36 -0700 From: Gleb Smirnoff To: Lexi Winter Cc: Ed Maste , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, imp@freebsd.org Subject: Re: git: 67783db661f8 - main - CONTRIBUTING: request only one submission type per change Message-ID: References: <202404181915.43IJFEoG020480@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Lexi, On Thu, Apr 18, 2024 at 08:27:56PM +0100, Lexi Winter wrote: L> as a non-committer src contributor, i've discussed this with imp@ quite L> a bit and i think this should be phrased more strongly in favour of L> using GitHub for commits. L> L> the current situation is that Phabricator is useless for non-committers L> because 1) you have to know who can review your commit, and 2) once your L> commit is reviewed, someone has to commit it, and Phabricator doesn't L> address this. The 1) is actually not as bad. Phabricator has subscribtion hooks, and many committers have rules installed to get notifications of new reviews that touch certain paths of code. The problem 2), IMHO, equally applies to github and Phabricator. L> i think it might make more sense to suggest that people submit all L> patches via either GitHub or Bugzilla, and only use Phabricator if L> specifically asked to. I don't agree here. Looks like we should address those phabricator submissions that go unnoticed due to lack of maintainers of a code. I don't think submitting same patch to github will improve visibility. -- Gleb Smirnoff