From owner-freebsd-multimedia@freebsd.org Sun Jul 22 19:50:34 2018 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3A04310541EB for ; Sun, 22 Jul 2018 19:50:34 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: from mail-oi0-x22f.google.com (mail-oi0-x22f.google.com [IPv6:2607:f8b0:4003:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A4848820A1 for ; Sun, 22 Jul 2018 19:50:33 +0000 (UTC) (envelope-from aliovx@gmail.com) Received: by mail-oi0-x22f.google.com with SMTP id l10-v6so29758276oii.0 for ; Sun, 22 Jul 2018 12:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5LHFQmauIGEghHMyGiz6mHnRLFwyETDB1GTykEAh2uE=; b=AF19nSOMdVveiLj2eTQZSiWlW3Rnhm53J0Kg8spr5S8Wpo5V8sWef61ALiTi/P5P2z 1aOAuQY/cgfZNVmyt5k8DbliizH0+FYCS1E9XKVJWyi0g5D7cEsbbz9MZP1NvkdOC9Gp hKa4ooBMMHnvLYGLofwj5XNdGiw3akLl677YIBaPa9UEolhWWj7FxFSu5W+fZPGPpdRV cxmt3eTiZZYY4vQ7Tp/YHr8AEn4GA56uOr6w4B5MoSersOutntVa+fsyPRZ128mW/yYc Bq8gBUKKDoBCXEBgb/HzVP/7+4ea4LzjDOUZ299Di7y2aJv2kwxNp3uVleQ+/TlG+2/l w1qQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5LHFQmauIGEghHMyGiz6mHnRLFwyETDB1GTykEAh2uE=; b=Sayohynn8xa79amhWd/Cj51/t5aeYQcnuRedGfmMhOnI8D422e5BFOBEQiAhgJL0dD MaRutv4NqMo6/T9C6iI0PO1dilOgwU6hMneZXewt65OQyz2wYTEYl76/E1A9t8J9Kk8O yvq/m7Ij4xVTu0G2U1QlGbQY3cajFoJaoBGuLL0u9DV0FTvJKuTN9JXxXHRff+nOtd4H wvJZDX5KrdGCEn93T224zWwNQGxzs3RtmGyRZWm6eP/B5/yF4JuBtTg3Mbga3IzVox0G IjaoMjwFGuUNttx8qfGJN9zbmN3Y9+BYJOc8m5+lY5+0r3R3Tx1r9o9QMfpA4g+QnfQa OESQ== X-Gm-Message-State: AOUpUlGDvVDSlmows8lQmjzXpcbbKFYJmD3oAlUrMzLMNWI9d7qukR5E 1KbzBPzBqvHuVnSQAEocdaPvRhdf2Wd/lC+bMbyd3l0r X-Google-Smtp-Source: AAOMgpcF1rfgB1eJo+lC0AkummJRbdBWlaaktJxtFXAEjVKtnx382KWmUSHUROvXrZP79P4i4vUzVJq4U4VvweNMr+0= X-Received: by 2002:aca:308f:: with SMTP id w137-v6mr6613994oiw.356.1532289032700; Sun, 22 Jul 2018 12:50:32 -0700 (PDT) MIME-Version: 1.0 References: <76c1ca5f-7a33-51c7-af7b-6e1003b39333@selasky.org> In-Reply-To: <76c1ca5f-7a33-51c7-af7b-6e1003b39333@selasky.org> From: Ali Abdallah Date: Sun, 22 Jul 2018 21:50:20 +0200 Message-ID: Subject: Re: mixer_info modify_counter To: hps@selasky.org Cc: freebsd-multimedia@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Jul 2018 19:50:34 -0000 Done. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=229969 Regards. On Sun, Jul 22, 2018 at 9:25 PM Hans Petter Selasky wrote: > On 07/22/18 20:08, Ali Abdallah wrote: > > Hello, > > > > Any reason why the modify_counter bit of mixer_info is not incremented > when > > the mixer gets changed? > > > >>From sys/dev/sound/pcm/mixer.c:70 > > /** > > * Counter is incremented when applications change any of this > > * mixer's controls. A change in value indicates that persistent > > * mixer applications should update their displays. > > */ > > > > But reading the code, it is clear that this is not the case, and the > > counter remains 0. It is enough to call m->modify_counter++ in mixer_set > on > > line 327 for example to make persistent mixer applications work > correctly. > > Currently they have to poll for all mixer controls, even if no changes > were > > made to the mixer. > > > > Hi, > > Can you create a PR and add a patch? > > --HPS > >