From owner-freebsd-current@FreeBSD.ORG  Tue Jul 27 05:28:38 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id EB82716A4CE
	for <current@freebsd.org>; Tue, 27 Jul 2004 05:28:38 +0000 (GMT)
Received: from robbins.dropbear.id.au (181.c.012.mel.iprimus.net.au
	[210.50.250.181])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F044643D5E
	for <current@freebsd.org>; Tue, 27 Jul 2004 05:28:37 +0000 (GMT)
	(envelope-from tim@robbins.dropbear.id.au)
Received: by robbins.dropbear.id.au (Postfix, from userid 1000)
	id 17D9E41FA; Tue, 27 Jul 2004 15:28:35 +1000 (EST)
Date: Tue, 27 Jul 2004 15:28:35 +1000
From: Tim Robbins <tjr@freebsd.org>
To: Nate Lawson <nate@root.org>
Message-ID: <20040727052835.GA714@cat.robbins.dropbear.id.au>
References: <20040726021326.GA23697@cat.robbins.dropbear.id.au>
	<20040726095929.GA30092@cat.robbins.dropbear.id.au>
	<4105BCAC.1000000@root.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4105BCAC.1000000@root.org>
User-Agent: Mutt/1.4.1i
cc: current@freebsd.org
cc: Marcel Moolenaar <marcel@xcllnt.net>
Subject: Re: Floppy disk drive no longer detected
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Jul 2004 05:28:39 -0000

On Mon, Jul 26, 2004 at 07:23:40PM -0700, Nate Lawson wrote:
> Tim Robbins wrote:
> >On Mon, Jul 26, 2004 at 12:13:26PM +1000, Tim Robbins wrote:
> >
> >>My floppy disk drive is no longer probed correctly by -CURRENT. I get the
> >>following message, but none about fd0 (and /dev/fd0 does not exist):
> >>
> >>fdc0: <floppy drive controller (FDE)> port 0x3f7,0x3f0-0x3f5 irq 6 drq 2 
> >>on acpi0
> >>
> >>Previously it probed as:
> >>
> >>fdc0: <Enhanced floppy controller (i82077, NE72065 or clone)> port 
> >>0x3f7,0x3f0-0x3f5 irq 6 drq 2 on acpi0
> >>fdc0: FIFO enabled, 8 bytes threshold
> >>fd0: <1440-KB 3.5" drive> on fdc0 drive 0
> >>
> >>The ACPI DSDT for this system is available at:
> >>http://people.freebsd.org/~tjr/k8v.txt.bz2
> >
> >
> >Ok, it looks like the FDC device should have a child device for each drive,
> >but my system's DSDT has none. Could we work around this in the driver by
> >not using _FDE/_FDI to probe unless the FDC device has at least 1 child 
> >with
> >an _FDI object, or should we add an entry to the quirks table for this
> >particular BIOS instead?
> 
> Here's another version of the patch.  It should fix _another_ problem I 
> found with Tim's BIOS, namely that it uses a package instead of a buffer 
> for _FDE.

This works nicely, thanks!


Tim