From owner-freebsd-hackers@FreeBSD.ORG  Wed Apr 25 14:15:30 2012
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 590BF1065677;
	Wed, 25 Apr 2012 14:15:30 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
	[IPv6:2001:470:1f10:75::2])
	by mx1.freebsd.org (Postfix) with ESMTP id 2E9258FC14;
	Wed, 25 Apr 2012 14:15:30 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8F773B95A;
	Wed, 25 Apr 2012 10:15:29 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: rank1seeker@gmail.com
Date: Wed, 25 Apr 2012 10:14:56 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p13; KDE/4.5.5; amd64; ; )
References: <20120421.164328.068.1@DOMY-PC>
	<201204231428.49712.jhb@freebsd.org>
	<20120425.133709.484.2@DOMY-PC>
In-Reply-To: <20120425.133709.484.2@DOMY-PC>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="windows-1250"
Content-Transfer-Encoding: 7bit
Message-Id: <201204251014.56568.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
	(bigwig.baldwin.cx); Wed, 25 Apr 2012 10:15:29 -0400 (EDT)
Cc: hackers@freebsd.org, dougb@freebsd.org
Subject: Re: Forgotten debuging flags in 9.0 RELEASE
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 25 Apr 2012 14:15:30 -0000

On Wednesday, April 25, 2012 9:37:09 am rank1seeker@gmail.com wrote:
> ----- Original Message -----
> From: John Baldwin <jhb@freebsd.org>
> To: freebsd-hackers@freebsd.org
> Cc: rank1seeker@gmail.com, dougb@freebsd.org
> Date: Mon, 23 Apr 2012 14:28:49 -0400
> Subject: Re: Forgotten debuging flags in 9.0 RELEASE
> 
> > On Saturday, April 21, 2012 12:43:28 pm rank1seeker@gmail.com wrote:
> > > Whenever I run:
> > > # make distribution
> > > 
> > > I also get:
> > > + ln -s ../var/named/etc/namedb /usr/TZONE/etc/namedb
> > > + ln -s mail/aliases /usr/TZONE/etc/aliases
> > > 
> > > Looks like someone forgot to turn off/remove debuging flags(set -x), 
before 
> > building 9.0 RELEASE
> > 
> > Actually, those have been there for at least 7 years.  The namedb one was 
> > first added in r136242, and the mail one is older than that.
> > 
> > > /usr/src/etc/Makefile:
> > > ----
> > >         @if [ ! -e ${DESTDIR}/etc/namedb ]; then \
> > >                 set -x; \
> > >                 ln -s ../var/named/etc/namedb ${DESTDIR}/etc/namedb; \
> > >         fi
> > > ----
> > >         @if [ -d ${DESTDIR}/etc/mail -a -f ${DESTDIR}/etc/mail/aliases -
a \
> > >               ! -f ${DESTDIR}/etc/aliases ]; then \
> > >                 set -x; \
> > >                 ln -s mail/aliases ${DESTDIR}/etc/aliases; \
> > >         fi
> > > ----
> > 
> > -- 
> > John Baldwin
> > 
> 
> 
> 7 years ?!?
> Wow, it's time to get rid of them, unless someone finds it criticaly 
useful/needed.

Alternatively, it hasn't broken anything in 7 years. :)

> My build script had many set -x lines, so I was thinking it was my script 
outputing it.
> I thought I was going mad, by being unable to find where am I using 'ln -s' 
lines, even after I've removed all 'set -x' lines

I will defer to dougb@ on this one as it is a chunk of the code he maintains.
You will have to convince him that the verbosity is somehow harmful.

-- 
John Baldwin