From owner-svn-src-all@FreeBSD.ORG Wed Oct 22 21:02:20 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 559051065675; Wed, 22 Oct 2008 21:02:20 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id BAEE68FC28; Wed, 22 Oct 2008 21:02:19 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.3/8.14.3) with ESMTP id m9ML2Ivr067573; Thu, 23 Oct 2008 01:02:18 +0400 (MSD) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1224709338; bh=qHRM6vlBDmbIPG5GcMbzDXtMsGUuSzj54Ud36GQ /qBw=; l=825; h=Date:From:To:Cc:Subject:Message-ID:References: MIME-Version:Content-Type:In-Reply-To; b=oukzVRUWRHzH0Yu9IQtvCp4Zj mOZImAy5LJeuO+f6G+qUY6hphdW/mhb0d7HkdnjEdMlagPdBUTFD2p5x2Id8S/dfkLI PQXXOmoJ/Q9Mv2dznFIO81cZ2ocFFaxnYdvgI60klHPNtI9X0A3poxfTnKwT/MTiJwF mxNP7RXycJXI= Received: (from ache@localhost) by nagual.pp.ru (8.14.3/8.14.3/Submit) id m9ML2IoU067572; Thu, 23 Oct 2008 01:02:18 +0400 (MSD) (envelope-from ache) Date: Thu, 23 Oct 2008 01:02:16 +0400 From: Andrey Chernov To: Konstantin Belousov Message-ID: <20081022210216.GA67445@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Konstantin Belousov , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org References: <200810221955.m9MJtCT9037516@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200810221955.m9MJtCT9037516@svn.freebsd.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r184177 - head/lib/libc/gen X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Oct 2008 21:02:20 -0000 On Wed, Oct 22, 2008 at 07:55:12PM +0000, Konstantin Belousov wrote: > Author: kib > Date: Wed Oct 22 19:55:12 2008 > New Revision: 184177 > URL: http://svn.freebsd.org/changeset/base/184177 > > Log: > Remove doubtful structure definition with variable array members. > I believe this is not a valid C99 construct. Use directly calculated > offsets into the supplied buffer, using specified members length, > to fill appropriate structure. > > Either use sysctl, or copy the value of the UNAME_x environment > variable, instead of unconditionally doing sysctl, and then > overriding a returned value with user-specified one. > > Noted and tested by: rdivacky Unfortunately on i386 this change cause segfaults in many programs at once (even in make(1)) -- http://ache.pp.ru/