From owner-cvs-all@FreeBSD.ORG Thu Sep 18 20:50:01 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 281571065676; Thu, 18 Sep 2008 20:50:01 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout020.mac.com (asmtpout020.mac.com [17.148.16.95]) by mx1.freebsd.org (Postfix) with ESMTP id 0E8968FC1C; Thu, 18 Sep 2008 20:50:01 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from vghiya-t60.jnpr.net (natint3.juniper.net [66.129.224.36]) by asmtp020.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0K7E0033FPPGUC70@asmtp020.mac.com>; Thu, 18 Sep 2008 12:48:54 -0700 (PDT) Message-id: <89B9A8BE-05F2-4DB2-B7B2-AB240AA9F0DD@mac.com> From: Marcel Moolenaar To: Marius Strobl In-reply-to: <20080918191947.GX94638@alchemy.franken.de> Date: Thu, 18 Sep 2008 12:48:52 -0700 References: <200809181356.m8IDuaxT089888@repoman.freebsd.org> <200809181027.51997.jhb@freebsd.org> <20080918191947.GX94638@alchemy.franken.de> X-Mailer: Apple Mail (2.929.2) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/sparc64/include smp.h src/sys/sparc64/sparc64 genassym.c mp_machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2008 20:50:01 -0000 On Sep 18, 2008, at 12:19 PM, Marius Strobl wrote: > On Thu, Sep 18, 2008 at 10:27:51AM -0400, John Baldwin wrote: >> On Thursday 18 September 2008 09:56:30 am Marius Strobl wrote: >>> marius 2008-09-18 13:56:30 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/sparc64/include smp.h >>> sys/sparc64/sparc64 genassym.c mp_machdep.c >>> Log: >>> SVN rev 183142 on 2008-09-18 13:56:30Z by marius >>> >>> - Newer firmware versions no longer provide SUNW,stop-self so just >>> disable interrupts and loop forever with these. >>> - Hide all MP-related bits in underneath #ifdef >>> SMP. >>> - Inline ipi_all_but_self(9) and ipi_selected(9). We don't expose >>> any >>> additional bits but save a few cycles by doing so. >>> - Remove ipi_all(9), which actually only called panic(9). It >>> can't be >>> implemented natively anyway and having it removed at least causes >>> MI users to fail already fail when linking. >> >> Should we just remove ipi_all() completely? >> > > Well, grepping in the CVS repository shows that there never was > an actually consumer of ipi_all() (only #ifdef'ed out ones in > ironically the sparc64 code) so it seems to be a good candidate > for axing. Generally I can't think of a reason why MI code would > want a CPU to send an IPI to itself. Actually, ipi_self() also > isn't and never was used in MI code, only in ia64 and powerpc > code for testing purposes. That's DS (=developer-specific) code rather than MI or MD code :-) Sending a test IPI to 'self' helps with bring-up or porting, but serves no real purpose (other than maybe a POST-like purpose) once IPIs are known to work... -- Marcel Moolenaar xcllnt@mac.com