Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Jan 2024 13:46:21 +0300
From:      Gleb Popov <arrowd@freebsd.org>
To:        Alexey Dokuchaev <danfe@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org,  dev-commits-ports-main@freebsd.org
Subject:   Re: git: d2e99e0393d6 - main - games/yadex: install the manpage under $PREFIX/share/man.
Message-ID:  <CALH631n1RA6g90bBB_m3AqznQNJ8xyxEe8MP3qRhx1vOeOAjjw@mail.gmail.com>
In-Reply-To: <Za5D2w0Y2gGhhaqG@FreeBSD.org>
References:  <202401220839.40M8dXYO009970@gitrepo.freebsd.org> <CALH631k2_Dw4n9a-eT8fNhf3BWHvPFpAKzZCCAFWfLm=sXkH3w@mail.gmail.com> <Za4uSwt9hMAbMEMu@FreeBSD.org> <CALH631np9RR0pq_9n3FRoXkxe0douQbpJJ3iGR-r%2BTGLcm-SAA@mail.gmail.com> <Za44NHtbyGzX2xAa@FreeBSD.org> <CALH631kk7Jqwt1_8xUjLVBrTQ67riDws=ajU8%2BfFvaYkcfV2tg@mail.gmail.com> <Za49mylJgNTt6xZp@FreeBSD.org> <CALH631nxx7y0aWzWNcXe3gr28g92s7d80Mp1Qb-GomGaYXKr9Q@mail.gmail.com> <Za5D2w0Y2gGhhaqG@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 22, 2024 at 1:30=E2=80=AFPM Alexey Dokuchaev <danfe@freebsd.org=
> wrote:
>
> Not sure I understand: to change default GNU_CONFIGURE_MANPREFIX you'd
> either have to fix all ports first (one by one, or better in small
> groups, e.g. per-category or per-maintainer), then flip the switch and
> drop custom GNU_CONFIGURE_MANPREFIX in indivitual ports (or skip/delay
> the drop because they would be redundant, but harmless), no?  You want
> to change everything in one big commit?  While I love to group commits,
> that would be a little *too* big, I reckon.
>
> ./danfe

It is not about commit squashing. The problem can be solved
incrementally but it introduces more churn in the repository:

1. We go over all affected ports plugging GNU_CONFIGURE_MANPREFIX
knobs into them.
2. Flip the switch in bsd.port.mk
3. Remove now useless GNU_CONFIGURE_MANPREFIX knobs from all the ports agai=
n.

As Mat said, it is easy to do 3 with a proper sed incantation, but I
wanted to avoid unnecessary changes in commits. Those can be avoided
if the work is being done in another branch, that'd get eventually
merged in and keep all the history lean.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CALH631n1RA6g90bBB_m3AqznQNJ8xyxEe8MP3qRhx1vOeOAjjw>