From owner-freebsd-arch@FreeBSD.ORG Fri Feb 6 01:40:45 2015 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E797BF64; Fri, 6 Feb 2015 01:40:44 +0000 (UTC) Received: from na01-bl2-obe.outbound.protection.outlook.com (mail-bl2on0111.outbound.protection.outlook.com [65.55.169.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "MSIT Machine Auth CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6B882C69; Fri, 6 Feb 2015 01:40:43 +0000 (UTC) Received: from BL2PR05CA0016.namprd05.prod.outlook.com (10.255.226.16) by BN1PR05MB439.namprd05.prod.outlook.com (10.141.58.22) with Microsoft SMTP Server (TLS) id 15.1.81.19; Fri, 6 Feb 2015 01:26:10 +0000 Received: from BL2FFO11FD022.protection.gbl (2a01:111:f400:7c09::181) by BL2PR05CA0016.outlook.office365.com (2a01:111:e400:c04::16) with Microsoft SMTP Server (TLS) id 15.1.75.20 via Frontend Transport; Fri, 6 Feb 2015 01:26:10 +0000 Received: from P-EMF02-SAC.jnpr.net (66.129.239.16) by BL2FFO11FD022.mail.protection.outlook.com (10.173.161.101) with Microsoft SMTP Server (TLS) id 15.1.87.10 via Frontend Transport; Fri, 6 Feb 2015 01:26:10 +0000 Received: from magenta.juniper.net (172.17.27.123) by P-EMF02-SAC.jnpr.net (172.24.192.21) with Microsoft SMTP Server (TLS) id 14.3.146.0; Thu, 5 Feb 2015 17:26:09 -0800 Received: from chaos.jnpr.net (chaos.jnpr.net [172.21.16.28]) by magenta.juniper.net (8.11.3/8.11.3) with ESMTP id t161Q8W69684; Thu, 5 Feb 2015 17:26:08 -0800 (PST) (envelope-from sjg@juniper.net) Received: from chaos (localhost [127.0.0.1]) by chaos.jnpr.net (Postfix) with ESMTP id 8B714580A3; Thu, 5 Feb 2015 17:26:08 -0800 (PST) To: NGie Cooper Subject: Re: Better way to do conditional inclusion in make In-Reply-To: References: <39C20BA1-E6B1-4DAE-95BB-8011A0A64D54@bsdimp.com> <54D40DC4.9070907@freebsd.org> Comments: In-reply-to: NGie Cooper message dated "Thu, 05 Feb 2015 17:06:55 -0800." From: "Simon J. Gerraty" X-Mailer: MH-E 8.0.3; nmh 1.3; GNU Emacs 22.3.1 Date: Thu, 5 Feb 2015 17:26:08 -0800 Message-ID: <5180.1423185968@chaos> MIME-Version: 1.0 Content-Type: text/plain X-EOPAttributedMessage: 0 Received-SPF: SoftFail (protection.outlook.com: domain of transitioning juniper.net discourages use of 66.129.239.16 as permitted sender) Authentication-Results: spf=softfail (sender IP is 66.129.239.16) smtp.mailfrom=sjg@juniper.net; freebsd.org; dkim=none (message not signed) header.d=none; X-Forefront-Antispam-Report: CIP:66.129.239.16; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(51444003)(51704005)(24454002)(46102003)(92566002)(117636001)(105596002)(106466001)(110136001)(6806004)(33716001)(50466002)(77096005)(76176999)(87936001)(1411001)(86362001)(57986006)(62966003)(77156002)(76506005)(47776003)(19580395003)(19580405001)(2950100001)(561944003)(48376002)(50226001)(50986999)(43043002)(42262002)(62816006); DIR:OUT; SFP:1102; SCL:1; SRVR:BN1PR05MB439; H:P-EMF02-SAC.jnpr.net; FPR:; SPF:SoftFail; MLV:nov; PTR:InfoDomainNonexistent; LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR05MB439; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004); SRVR:BN1PR05MB439; X-Forefront-PRVS: 047999FF16 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR05MB439; X-OriginatorOrg: juniper.net X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2015 01:26:10.3332 (UTC) X-MS-Exchange-CrossTenant-Id: bea78b3c-4cdb-4130-854a-1d193232e5f4 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=bea78b3c-4cdb-4130-854a-1d193232e5f4; Ip=[66.129.239.16] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR05MB439 Cc: "freebsd-arch@freebsd.org" X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 01:40:45 -0000 NGie Cooper wrote: > > how does it cope with the case where a single file is dependent on either of > > two options. > > (we have this in our tree.. not sure if it occurs in the FreeBSD tree.) > > file could occur in both lists or twice in one list.. > > This is a good, valid point. I think that Warner's proposal will fix > the simple case (using one knob), but not the more complex case. FILES:= ${FILES:O:u} should cover that case. > What concerns me about the short description of the implementation, > (and something that I'm going to add to the phabricator review) is > that this will: > > 1. Break using FILESGROUPS Why? > 2. Requires creating snippets for dealing with magic in bsd.*.mk (I > wouldn't want this magic going into the general purpose snippets > because it would probably break backwards compatibility). Not necessarily eg. if you clean/simplify the list after building it.