From owner-freebsd-bugs@FreeBSD.ORG Mon Dec 31 03:00:00 2012 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A882527D for ; Mon, 31 Dec 2012 03:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 71F998FC12 for ; Mon, 31 Dec 2012 03:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id qBV300mN047513 for ; Mon, 31 Dec 2012 03:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id qBV300OJ047512; Mon, 31 Dec 2012 03:00:00 GMT (envelope-from gnats) Resent-Date: Mon, 31 Dec 2012 03:00:00 GMT Resent-Message-Id: <201212310300.qBV300OJ047512@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mike Karels Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9BB1EF5A for ; Mon, 31 Dec 2012 02:55:47 +0000 (UTC) (envelope-from Mike_Karels@mcafee.com) Received: from DNVWSMAILOUT1.mcafee.com (dnvwsmailout1.mcafee.com [161.69.31.173]) by mx1.freebsd.org (Postfix) with ESMTP id 51A098FC13 for ; Mon, 31 Dec 2012 02:55:46 +0000 (UTC) Received: from DNVEXAMER2N1.corp.nai.org (unknown [10.44.48.21]) by DNVWSMAILOUT1.mcafee.com with smtp id 727b_1d9e_8ea6665a_9933_46da_a1fe_f4540cbaacbc; Sun, 30 Dec 2012 20:55:37 -0600 Received: from DNVEXAPP1N1.corp.nai.org (10.44.48.61) by DNVEXAMER2N1.corp.nai.org (10.44.48.21) with Microsoft SMTP Server (TLS) id 14.2.318.1; Sun, 30 Dec 2012 19:55:38 -0700 Received: from frodo.scur.com (10.44.48.242) by mail.na.nai.com (10.44.48.61) with Microsoft SMTP Server id 14.2.318.1; Sun, 30 Dec 2012 19:55:37 -0700 Received: from mcafee.com (localhost [127.0.0.1]) by frodo.scur.com (8.14.5/8.14.5) with ESMTP id qBV2tb8h051126 for ; Sun, 30 Dec 2012 20:55:37 -0600 (CST) (envelope-from mkarels@mcafee.com) Received: (from mkarels@localhost) by mcafee.com (8.14.5/8.14.5/Submit) id qBV2tblh051125; Sun, 30 Dec 2012 20:55:37 -0600 (CST) (envelope-from mkarels) Message-Id: <201212310255.qBV2tblh051125@mcafee.com> Date: Sun, 30 Dec 2012 20:55:37 -0600 From: Mike Karels To: X-Send-Pr-Version: 3.113 Subject: kern/174849: bxe driver can hang kernel when reset X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Mike Karels List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2012 03:00:00 -0000 >Number: 174849 >Category: kern >Synopsis: bxe driver can hang kernel when reset >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Dec 31 03:00:00 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Mike Karels >Release: FreeBSD 10.0-CURRENT amd64 >Organization: McAfee, Inc >Environment: System: FreeBSD freebsd-current.karels.net 10.0-CURRENT FreeBSD 10.0-CURRENT #1 r244048: Sun Dec 9 18:48:31 UTC 2012 root@snap.freebsd.org:/usr/obj/usr/src/sys/GENERIC amd64 >Description: Resetting the bxe driver can hang the kernel. Note: problem was found and fixed on a FreeBSD 8.2 derivative; the patch compiles with -current. >How-To-Repeat: ifconfig bxe0 down; ifconfig bxe0 up >Fix: --- if_bxe.c.orig 2012-12-22 19:56:36.000000000 -0600 +++ if_bxe.c 2012-12-22 20:17:12.000000000 -0600 @@ -9610,8 +9610,10 @@ __FUNCTION__, fp->index); BXE_FP_LOCK(fp); - while ((m = buf_ring_dequeue_sc(fp->br)) != NULL) + while ((m = buf_ring_dequeue_sc(fp->br)) != NULL) { m_freem(m); + fp->br = NULL; + } BXE_FP_UNLOCK(fp); } } >Release-Note: >Audit-Trail: >Unformatted: