From owner-cvs-all Tue Jan 12 14:38:23 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id OAA22074 for cvs-all-outgoing; Tue, 12 Jan 1999 14:38:23 -0800 (PST) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from ns1.yes.no (ns1.yes.no [195.204.136.10]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id OAA22057 for ; Tue, 12 Jan 1999 14:38:16 -0800 (PST) (envelope-from eivind@bitbox.follo.net) Received: from bitbox.follo.net (bitbox.follo.net [195.204.143.218]) by ns1.yes.no (8.9.1a/8.9.1) with ESMTP id XAA13181; Tue, 12 Jan 1999 23:37:35 +0100 (CET) Received: (from eivind@localhost) by bitbox.follo.net (8.8.8/8.8.6) id XAA72146; Tue, 12 Jan 1999 23:37:34 +0100 (MET) Date: Tue, 12 Jan 1999 23:37:33 +0100 From: Eivind Eklund To: John Birrell Cc: Archie Cobbs , mike@smith.net.au, luigi@labinfo.iet.unipi.it, cvs-committers@FreeBSD.ORG Subject: Re: cvs commit: src/sys/netinet ip_input.c Message-ID: <19990112233733.B71402@bitbox.follo.net> References: <199901122124.NAA07208@bubba.whistle.com> <199901122137.IAA08522@cimlogic.com.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <199901122137.IAA08522@cimlogic.com.au>; from John Birrell on Wed, Jan 13, 1999 at 08:37:34AM +1100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk On Wed, Jan 13, 1999 at 08:37:34AM +1100, John Birrell wrote: > If you are working on a "problem child" in the tree and in doing so > you choose to compile without optimisation, your build is likely to > fail due to -Werror barfing on static inline definitions in the headers > that aren't used. This is *really* annoying. I removed -Werror from a > couple of places in the tree when porting stuff to alpha because of > this. > > If people want to _add_ -Werror in their local /etc/make.conf, by all > means do so, but please don't make it required. What I am planning to do (unless I get shouted down by more than one voice) is to add it to bsd.kern.mk, with a knob in /etc/make.conf to turn it off. If it is not on by default, people will keep committing bogus code. Eivind. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message