From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jul 12 12:30:23 2005 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D4B216A41C for ; Tue, 12 Jul 2005 12:30:23 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 025F343D46 for ; Tue, 12 Jul 2005 12:30:22 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j6CCUMKH025438 for ; Tue, 12 Jul 2005 12:30:22 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j6CCUM4k025437; Tue, 12 Jul 2005 12:30:22 GMT (envelope-from gnats) Resent-Date: Tue, 12 Jul 2005 12:30:22 GMT Resent-Message-Id: <200507121230.j6CCUM4k025437@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Sven Berkvens-Matthijsse Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5C2B316A41C for ; Tue, 12 Jul 2005 12:22:06 +0000 (GMT) (envelope-from sven@serv7.ilse.net) Received: from serv1.ilse.net (serv1.ilse.net [62.69.160.11]) by mx1.FreeBSD.org (Postfix) with ESMTP id B3CA043D46 for ; Tue, 12 Jul 2005 12:22:05 +0000 (GMT) (envelope-from sven@serv7.ilse.net) Received: from serv7.ilse.net (serv7.ilse.net [10.1.8.17]) by serv1.ilse.net (8.12.10/8.10.2) with ESMTP id j6CCM3rD004462 for ; Tue, 12 Jul 2005 14:22:03 +0200 (MEST) Received: (from sven@localhost) by serv7.ilse.net (8.13.3/8.11.1) id j6CCM2Er019191; Tue, 12 Jul 2005 14:22:02 +0200 (CEST) (envelope-from sven) Message-Id: <200507121222.j6CCM2Er019191@serv7.ilse.net> Date: Tue, 12 Jul 2005 14:22:02 +0200 (CEST) From: Sven Berkvens-Matthijsse To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/83326: [PATCH] audio/vorbis-tools does compile with gcc 2.95 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sven Berkvens-Matthijsse List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2005 12:30:23 -0000 >Number: 83326 >Category: ports >Synopsis: [PATCH] audio/vorbis-tools does compile with gcc 2.95 >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Jul 12 12:30:22 GMT 2005 >Closed-Date: >Last-Modified: >Originator: Sven Berkvens-Matthijsse >Release: FreeBSD 4.10-STABLE i386 >Organization: ilse media >Environment: System: FreeBSD serv7.ilse.net 4.10-STABLE FreeBSD 4.10-STABLE #23: Wed Aug 4 15:18:52 CEST 2004 root@tango.ilse.net:/usr/obj/usr/src/sys/BAROQUE i386 >Description: The audio/vorbis-tools port does not compile with gcc 2.95 because a variable declaration is introduced in a block where this is not allowed in C90. >How-To-Repeat: Try to compile vorbis-tools with gcc 2.95 (FreeBSD 4 default). >Fix: The following patch solves the problem (this is the contents of a new file /usr/ports/audio/vorbis-tools/files/patch-oggenc_encode.c): --- oggenc/encode.c.orig Tue Jul 12 14:06:35 2005 +++ oggenc/encode.c Tue Jul 12 14:06:40 2005 @@ -160,6 +160,7 @@ /* do we have optional hard bitrate restrictions? */ if(opt->max_bitrate > 0 || opt->min_bitrate > 0){ struct ovectl_ratemanage2_arg ai; + long bitrate; vorbis_encode_ctl(&vi, OV_ECTL_RATEMANAGE2_GET, &ai); /* libvorbis 1.1 (and current svn) doesn't actually fill this in, @@ -173,7 +174,6 @@ Also, note that this won't work correctly unless you have a very recent (2005/03/04 or later) version of libvorbis from svn). */ - long bitrate; { vorbis_info vi2; >Release-Note: >Audit-Trail: >Unformatted: