From owner-cvs-all@FreeBSD.ORG Sat Jul 14 08:12:25 2012 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C39A91065670; Sat, 14 Jul 2012 08:12:25 +0000 (UTC) (envelope-from cvs-src@yandex.ru) Received: from forward19.mail.yandex.net (forward19.mail.yandex.net [IPv6:2a02:6b8:0:1402::4]) by mx1.freebsd.org (Postfix) with ESMTP id CB1888FC0A; Sat, 14 Jul 2012 08:12:24 +0000 (UTC) Received: from smtp19.mail.yandex.net (smtp19.mail.yandex.net [95.108.252.19]) by forward19.mail.yandex.net (Yandex) with ESMTP id 2BC081121D09; Sat, 14 Jul 2012 12:12:23 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1342253543; bh=jb9czMrEa6up+kLbyn2W3KBPYVoAcZMIoOGibPw3T8Q=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=DEUfbuAzQku469teHS3IDef0Wb9Wvn55o8w0pMpqyBiPODSQeYlCzbrBE8rkDPOBP OTdM5mXKfylYoCL7Vj/hAD/yaNUkllTrMjkqZ+wlF1FFRLPPFHdJJwrdPCBruK+dKM V0K9IyRHuWhEdUEi5pMDPSxNLheTLkZEjJcTB+Q0= Received: from smtp19.mail.yandex.net (localhost [127.0.0.1]) by smtp19.mail.yandex.net (Yandex) with ESMTP id BF1E4BE04AE; Sat, 14 Jul 2012 12:12:22 +0400 (MSK) Received: from unknown (unknown [178.76.224.133]) by smtp19.mail.yandex.net (nwsmtp/Yandex) with ESMTP id CLmWZXVp-CMmK6vrb; Sat, 14 Jul 2012 12:12:22 +0400 X-Yandex-Rcpt-Suid: matthew@FreeBSD.org X-Yandex-Rcpt-Suid: danfe@FreeBSD.org X-Yandex-Rcpt-Suid: kwm@FreeBSD.org X-Yandex-Rcpt-Suid: ports-committers@FreeBSD.org X-Yandex-Rcpt-Suid: cvs-ports@FreeBSD.org X-Yandex-Rcpt-Suid: cvs-all@FreeBSD.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1342253542; bh=jb9czMrEa6up+kLbyn2W3KBPYVoAcZMIoOGibPw3T8Q=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=k26n0oypWmed94WNESawmXwNFU+UT6sx09PxqVSajpK32JNXN/eIIU8MsUg4/ZNDR fy+8Y13tUDh4eJUDOaD84ppCva8UnSI6K0qA2xnPuowFL/jAn/LaqwZg4UU1iBkTG/ rSbgLTWJjTqTbCIi/0ZKDpw805w6JmIa83hBYX5o= Message-ID: <5001298C.5020701@yandex.ru> Date: Sat, 14 Jul 2012 12:10:52 +0400 From: Ruslan Mahmatkhanov User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:13.0) Gecko/20120619 Thunderbird/13.0.1 MIME-Version: 1.0 To: Matthew Seaman References: <201207131023.q6DANo8l081040@repoman.freebsd.org> <20120714070300.GA55269@FreeBSD.org> <500120A8.700@yandex.ru> <20120714075126.GA62010@FreeBSD.org> <50012859.1080906@FreeBSD.org> In-Reply-To: <50012859.1080906@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Koop Mast , Alexey Dokuchaev , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/gcompris Makefile distinfo pkg-descr pkg-plist X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2012 08:12:26 -0000 Matthew Seaman wrote on 14.07.2012 12:05: > On 14/07/2012 08:51, Alexey Dokuchaev wrote: >> On Sat, Jul 14, 2012 at 11:32:56AM +0400, Ruslan Mahmatkhanov wrote: >>> Alexey Dokuchaev wrote on 14.07.2012 11:03: >>>> On Fri, Jul 13, 2012 at 10:23:50AM +0000, Koop Mast wrote: >>>>> kwm 2012-07-13 10:23:50 UTC >>>>> >>>>> Modified files: >>>>> games/gcompris Makefile distinfo pkg-descr pkg-plist >>>>> Log: >>>>> [...] >>>>> Add tab in WWW line in pkg-descr. >>>> >>>> I think the last change takes us backwards: space is preferred separator in >>>> WWW: line of pkg-descr AFAICT. >>> >>> I always replace this space with a tab (in a manner as vars and values >>> are separated in Makefile). Does it documented somewhere? And what the >>> reason may be of space is preferable? Thanks. >> >> Well, pkg-descr is not a Makefile. In makefiles, tabs help to align the >> values nicely, as it helps readability a lot. On the contrary, pkg-descr is >> mostly simple text, so there is not need to abuse tab here where single >> space perfectly suffices and IMHO looks a lot better. >> >> Sadly, as with other stylish rather than functional issues, it does not seem >> to be documented. Hopefully after switch to SVN it would be easier to >> isolate this kind of mechanical commits, and I will ask permission to >> convert every port to single space + submit a patch to someone on doc@ team >> to be added to PH. > > Actually, it would make a lot of sense to take the WWW entries out of > pkg-descr files entirely, and have them a variable in the main port > Makefile instead. > > This would, at a stroke, reduce the number of files that need to be read > to generate the INDEX by a factor of around 2, and consequentially speed > things up. > > Cheers, > > Matthew +1. I also want to say that this is the only string that's parsed by various scripts, so it's more "service line", than simple text. -- Regards, Ruslan Tinderboxing kills... the drives.