From owner-cvs-ports@FreeBSD.ORG Thu Jan 5 09:52:02 2006 Return-Path: X-Original-To: cvs-ports@FreeBSD.org Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 288DE16A41F; Thu, 5 Jan 2006 09:52:02 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: from mail2out.barnet.com.au (mail2out.barnet.com.au [202.83.176.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id 240AC43D5E; Thu, 5 Jan 2006 09:51:58 +0000 (GMT) (envelope-from edwin@mavetju.org) Received: by mail2out.barnet.com.au (Postfix, from userid 27) id 0A4B27073DE; Thu, 5 Jan 2006 20:51:57 +1100 (EST) X-Viruscan-Id: <43BCEC3C00009F29AFDEF2@BarNet> Received: from mail2-auth.barnet.com.au (mail2.barnet.com.au [202.83.176.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "*.barnet.com.au", Issuer "BarNet Root Certificate Authority" (verified OK)) by mail2.barnet.com.au (Postfix) with ESMTP id B902D7073D8; Thu, 5 Jan 2006 20:51:56 +1100 (EST) Received: from k7.mavetju (edwin-3.int.barnet.com.au [10.10.12.2]) by mail2-auth.barnet.com.au (Postfix) with ESMTP id 3D7887073D7; Thu, 5 Jan 2006 20:51:56 +1100 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id DBE79284; Thu, 5 Jan 2006 20:51:55 +1100 (EST) Date: Thu, 5 Jan 2006 20:51:55 +1100 From: Edwin Groothuis To: ports-committers@FreeBSD.org, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org Message-ID: <20060105095155.GS3805@k7.mavetju> References: <200601042032.k04KWG0F024079@repoman.freebsd.org> <20060105082118.GO71724@droso.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060105082118.GO71724@droso.net> User-Agent: Mutt/1.4.2.1i Cc: Subject: Re: cvs commit: ports/astro/xglobe Makefile ports/astro/xglobe/files patch-renderer.cpp X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jan 2006 09:52:02 -0000 On Thu, Jan 05, 2006 at 09:21:19AM +0100, Erwin Lansing wrote: > > PR: ports/82270 > > Submitted by: Florian Smeets > > Reviewed by: edwin@FreeBSD.org > > Review is implicit if you commit it. Sometimes it's more review than other times. For this one, I actually checked if it was doing what it said it did, instead of seeing if it compiled and installed properly. Edwin -- Edwin Groothuis | Personal website: http://www.mavetju.org edwin@mavetju.org | Weblog: http://weblog.barnet.com.au/edwin/