From owner-svn-ports-all@FreeBSD.ORG  Mon Dec 31 18:04:52 2012
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
 by hub.freebsd.org (Postfix) with ESMTP id 421F9846;
 Mon, 31 Dec 2012 18:04:52 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-ia0-f178.google.com (mail-ia0-f178.google.com
 [209.85.210.178])
 by mx1.freebsd.org (Postfix) with ESMTP id B0B5F8FC0C;
 Mon, 31 Dec 2012 18:04:51 +0000 (UTC)
Received: by mail-ia0-f178.google.com with SMTP id k25so10633196iah.37
 for <multiple recipients>; Mon, 31 Dec 2012 10:04:45 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=3MP05XZT3dpyKnuUz6Nj7mwp2MbGQDdO2j6voP/Hnsc=;
 b=FUVRypqYqi0LlrumQ9GA/kGNdtkoNcfNHCTGKD20/oKI6UCdC+1wFwYGBZVGi4BQag
 It/bIoWFjPmrg0i5f2Xo8PXujNaKhdEAkSivdxbuWwyzmH72cLVhO8oISpHj/y2qCKIB
 P1uQlZutYPc7SoqnPjNFsl3M/mu6ksgTuKXDmxFK+3tswuaPg/IdnX5/SNBA0ioZsi+N
 hkxrlC09En7f+/edhJ5fp30tqVWlfbb/DFtPOxgllXeN5HZfGV5MQ4JK1zJ/zcKXKtRx
 rGkYhKQQK7/qwKBN+gXEA/wef+55zQQJ12PUoDuhgT8abWh4Jbi4XlAryUY0v6PA81f5
 GupA==
MIME-Version: 1.0
Received: by 10.50.158.170 with SMTP id wv10mr32024364igb.75.1356976621457;
 Mon, 31 Dec 2012 09:57:01 -0800 (PST)
Received: by 10.64.65.132 with HTTP; Mon, 31 Dec 2012 09:57:01 -0800 (PST)
Received: by 10.64.65.132 with HTTP; Mon, 31 Dec 2012 09:57:01 -0800 (PST)
In-Reply-To: <CAMuy=+iMANJ_3G9LHwsxPrai+xhE3Ryj9rd8j0Z0zodGg82Wmw@mail.gmail.com>
References: <201212310346.qBV3kR0W049479@svn.freebsd.org>
 <8701822.2t1vcGT59x@mocha.verizon.net>
 <CAMuy=+iMANJ_3G9LHwsxPrai+xhE3Ryj9rd8j0Z0zodGg82Wmw@mail.gmail.com>
Date: Mon, 31 Dec 2012 17:57:01 +0000
Message-ID: <CADLo83_0YCzKUk28w6y1EHa9TiAoHN6bFcF3Dt9F1+rFQ7FfGw@mail.gmail.com>
Subject: Re: svn commit: r309705 - in head/irc: . dxirc
From: Chris Rees <utisoft@gmail.com>
To: Jason Helfman <jgh@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.14
Cc: svn-ports-head@freebsd.org, Baptiste Daroussin <bapt@freebsd.org>,
 "Jason E. Hale" <jhale@freebsd.org>, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 31 Dec 2012 18:04:52 -0000

On 31 Dec 2012 17:49, "Jason Helfman" <jgh@freebsd.org> wrote:
>
> On Mon, Dec 31, 2012 at 6:06 AM, Jason E. Hale <jhale@freebsd.org> wrote:
>>
>> On Monday, December 31, 2012 03:46:27 Jason Helfman wrote:
>> > Added: head/irc/dxirc/Makefile
>> >
============================================================================
>> > --- /dev/null   00:00:00 1970   (empty, because file is newly added)
>> > +++ head/irc/dxirc/Makefile     Mon Dec 31 03:46:26 2012
 (r309705)
>> > @@ -0,0 +1,80 @@
>> >
>> > +LICENSE=     GPLv3
>> > +LICENSE_FILE=        ${WRKSRC}/COPYING
>>
>> LICENSE_FILE should be dropped for standard license
>>
>
> Did you compare the license files before making this comment?

Hm, modifying the GPL is forbidden; how different is it?

>> > +LIB_DEPENDS= FOX-1:${PORTSDIR}/x11-toolkits/fox16
>>
>> The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI
>> version number.
>>
>
> Another reason to drop the ABI warning from portlint. Builds still passed
with, and without it. I will restore it. IMHO I am not in favor of portlint
warnings for this.
>
>>
>> > +OPTIONS_DEFINE=      NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY
>> > +OPTIONS_DEFAULT=     NLS TRAY IPV6 SSL LUA
>>
>> NLS doesn't need to be in OPTIONS_DEFAULT...it is already default.
 Might as
>> well add DOCS to OPTIONS_DEFINE too.
>>
> I wanted to honor what the contributor wanted for defaults in the future
if the defaults ever are to change. I don't see how naming them explicitly
is a problem.
>
>>
>> > Added: head/irc/dxirc/pkg-plist
>> >
============================================================================
>> > == --- /dev/null      00:00:00 1970   (empty, because file is newly
added)
>> > +++ head/irc/dxirc/pkg-plist  Mon Dec 31 03:46:26 2012        (r309705)
>> > @@ -0,0 +1,297 @@
>> > +%%DATADIR%%/COPYING
>>
>> Since LICENSE is already defined, the installation of an additional
license
>> file should be squashed.
>
>
> Good catch. Thanks!
>
>>
>>
>> > +@dirrm share/applications
>>
>> This should be a @dirrmtry since it is a shared directory.
>>
>
> Good catch. Thanks!
>
> -jgh