From owner-freebsd-bugs@FreeBSD.ORG  Fri Nov 19 10:10:27 2004
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id B0C3316A588
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 19 Nov 2004 10:10:27 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9F01943D54
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 19 Nov 2004 10:10:27 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.11/8.12.11) with ESMTP id iAJAARUf051335
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 19 Nov 2004 10:10:27 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.12.11/8.12.11/Submit) id iAJAARf0051334;
	Fri, 19 Nov 2004 10:10:27 GMT
	(envelope-from gnats)
Date: Fri, 19 Nov 2004 10:10:27 GMT
Message-Id: <200411191010.iAJAARf0051334@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Yar Tikhiy <yar@comp.chem.msu.su>
Subject: Re: kern/72933: [patch] promisc mode on vlan interface does not
	work correctly
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: Yar Tikhiy <yar@comp.chem.msu.su>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Nov 2004 10:10:27 -0000

The following reply was made to PR kern/72933; it has been noted by GNATS.

From: Yar Tikhiy <yar@comp.chem.msu.su>
To: freebsd-gnats-submit@FreeBSD.org, blackv@netroad.ru
Cc:  
Subject: Re: kern/72933: [patch] promisc mode on vlan interface does not work correctly
Date: Fri, 19 Nov 2004 13:05:04 +0300

 Hi there,
 
 While the fix you proposed looks really reasonable, I cannot see
 how it helps in your particular case.  If you look at the code,
 you'll see that the first conditional there is !BDG_ACTIVE(ifp),
 which isn't true in your setting.  Any ideas?
 
 By the way, would you mind using context or unified diff format?
 Telling "change file bar.c line number X to FOO" isn't a good way
 of sending patches since it isn't robust to other changes that may
 have happened to the source file in the meantime.  Moreover, the
 said format gives context to discuss the code in while your way
 doesn't.  Thanks.
 
 -- 
 Yar